Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

BR: retry for PD request error and TiKV IO error (#27803) #1433

Merged
merged 5 commits into from
Sep 9, 2021

Conversation

joccau
Copy link
Member

@joccau joccau commented Sep 7, 2021

What problem does this PR solve?

Cherry-pick for pr(pingcap/tidb#27803) to fix issue(pingcap/tidb#27787)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

Retry pd request and TiKV IO timeout error

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@joccau
Copy link
Member Author

joccau commented Sep 7, 2021

/rebuild

@joccau
Copy link
Member Author

joccau commented Sep 7, 2021

/run-integration-test

@joccau
Copy link
Member Author

joccau commented Sep 7, 2021

./build

@joccau
Copy link
Member Author

joccau commented Sep 8, 2021

/build

@kennytm
Copy link
Collaborator

kennytm commented Sep 8, 2021

please fix gofmt.

[2021-09-08T03:11:33.854Z]  	"google.golang.org/grpc/credentials"

[2021-09-08T03:11:33.854Z]  	"google.golang.org/grpc/keepalive"

[2021-09-08T03:11:33.854Z]  

[2021-09-08T03:11:33.854Z] +	"google.golang.org/grpc/status"

[2021-09-08T03:11:33.854Z] +

[2021-09-08T03:11:33.854Z]  	berrors "github.com/pingcap/br/pkg/errors"

[2021-09-08T03:11:33.854Z]  	"github.com/pingcap/br/pkg/glue"

[2021-09-08T03:11:33.854Z]  	"github.com/pingcap/br/pkg/logutil"

[2021-09-08T03:11:33.854Z]  	"github.com/pingcap/br/pkg/pdutil"

[2021-09-08T03:11:33.854Z]  	"github.com/pingcap/br/pkg/utils"

[2021-09-08T03:11:33.854Z]  	"github.com/pingcap/br/pkg/version"

[2021-09-08T03:11:33.854Z] -	"google.golang.org/grpc/status"

@kennytm
Copy link
Collaborator

kennytm commented Sep 8, 2021

now it's the lints 😅

[2021-09-08T09:15:33.066Z]   ✘  https://revive.run/r#exported  exported function GetAllTiKVStoresWithRetry should have comment or be unexported  
[2021-09-08T09:15:33.066Z]   /home/jenkins/agent/workspace/br_ghpr_build/go/src/github.com/pingcap/br/pkg/conn/conn.go:109:1
[2021-09-08T09:15:33.066Z] 
[2021-09-08T09:15:33.067Z]   ✘  https://revive.run/r#exported  exported function NewImportSSTBackoffer should have comment or be unexported  
[2021-09-08T09:15:33.067Z]   /home/jenkins/agent/workspace/br_ghpr_build/go/src/github.com/pingcap/br/pkg/utils/backoff.go:47:1
[2021-09-08T09:15:33.067Z] 
[2021-09-08T09:15:33.067Z]   ✘  https://revive.run/r#exported  exported function NewDownloadSSTBackoffer should have comment or be unexported  
[2021-09-08T09:15:33.067Z]   /home/jenkins/agent/workspace/br_ghpr_build/go/src/github.com/pingcap/br/pkg/utils/backoff.go:51:1
[2021-09-08T09:15:33.067Z] 
[2021-09-08T09:15:33.067Z]   ✘  https://revive.run/r#exported  exported function NewPDReqBackoffer should have comment or be unexported  
[2021-09-08T09:15:33.067Z]   /home/jenkins/agent/workspace/br_ghpr_build/go/src/github.com/pingcap/br/pkg/utils/backoff.go:97:1

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

pkg/conn/conn.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Sep 8, 2021
joccau and others added 2 commits September 8, 2021 18:45
@YuJuncen
Copy link
Collaborator

YuJuncen commented Sep 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9b032f2

ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Sep 17, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1436.

ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Sep 17, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1437.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants