Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[3.1] restore: Make all download error as retryable (#298) #314

Merged
merged 6 commits into from
May 29, 2020

Conversation

kennytm
Copy link
Collaborator

@kennytm kennytm commented May 27, 2020

What problem does this PR solve?

Cherry-pick #298 to release-3.1

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release Note

  • Improved robustness of restore, reducing chance of failure due to transient network error with cloud storage.

@overvenus
Copy link
Member

Please fix CI, thanks!

@kennytm kennytm added the status/LGT1 LGTM1 label May 27, 2020
@kennytm kennytm force-pushed the cherry-pick-298-to-3.1 branch from 585eb26 to 8dac5af Compare May 27, 2020 17:59
@kennytm kennytm force-pushed the cherry-pick-298-to-3.1 branch from 8dac5af to cc3cae7 Compare May 27, 2020 19:12
@overvenus
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

Your auto merge job has been accepted, waiting for:

  • 321

@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

@kennytm merge failed.

@kennytm
Copy link
Collaborator Author

kennytm commented May 29, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

@kennytm merge failed.

@kennytm
Copy link
Collaborator Author

kennytm commented May 29, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #314 into release-3.1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-3.1     #314   +/-   ##
============================================
  Coverage        70.46%   70.46%           
============================================
  Files               48       48           
  Lines             5005     5005           
============================================
  Hits              3527     3527           
  Misses            1009     1009           
  Partials           469      469           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d690a8b...24af375. Read the comment docs.

@kennytm kennytm force-pushed the cherry-pick-298-to-3.1 branch from 0c0ce6e to e89eb5c Compare May 29, 2020 09:09
@kennytm
Copy link
Collaborator Author

kennytm commented May 29, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

/run-all-tests

@sre-bot sre-bot merged commit 7d539bb into pingcap:release-3.1 May 29, 2020
@kennytm kennytm deleted the cherry-pick-298-to-3.1 branch May 29, 2020 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants