Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

storage/: handle special character in URL #614

Merged
merged 7 commits into from
Nov 25, 2020

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

#603

What is changed and how it works?

replace the '+' to %2B in the url.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Note

  • handle the special character in br URL

@lichunzhu lichunzhu changed the title handle special character in URL storage/: handle special character in URL Nov 24, 2020
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tests/br_s3/run.sh Outdated Show resolved Hide resolved
tests/br_s3/run.sh Outdated Show resolved Hide resolved
pkg/storage/parse.go Show resolved Hide resolved
tests/br_s3/run.sh Outdated Show resolved Hide resolved
@lichunzhu lichunzhu force-pushed the handleSpecialCharacter branch from 3c0e349 to 897ead4 Compare November 24, 2020 12:47
tests/br_s3/run.sh Outdated Show resolved Hide resolved
Co-authored-by: kennytm <kennytm@gmail.com>
@lichunzhu
Copy link
Contributor Author

/run-all-tests

1 similar comment
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@3pointer 3pointer added this to the v4.0.9 milestone Nov 25, 2020
@lichunzhu
Copy link
Contributor Author

/run-all-tests

1 similar comment
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@lichunzhu
Copy link
Contributor Author

/run-integration-tests

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Nov 25, 2020
Copy link
Collaborator

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Nov 25, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #617

@lichunzhu lichunzhu deleted the handleSpecialCharacter branch November 25, 2020 08:38
3pointer pushed a commit that referenced this pull request Nov 25, 2020
* handle special character in URL

* Update tests/br_s3/run.sh

Co-authored-by: kennytm <kennytm@gmail.com>

* clear data

* try to fix

* add comment and a unit test

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
Co-authored-by: Chunzhu Li <lichunzhu@pingcap.com>
Co-authored-by: kennytm <kennytm@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants