Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to support dbt-core v1.6.4 #52

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Dieken
Copy link
Contributor

@Dieken Dieken commented Oct 2, 2023

Actually this should work for dbt-core>=1.4.0 but I didn't test against old verions of dbt-core.

Tested against Python 3.8 and 3.11, TiDB 6.5.5.

See dbt-labs/dbt-core#6624

XxxException -> DbtXxxError
raise_compiler_error -> CompilationError

@sre-bot
Copy link

sre-bot commented Oct 2, 2023

CLA assistant check
All committers have signed the CLA.

@Dieken Dieken changed the title Migrate to support dbt-core v1.6.4 upgrade to support dbt-core v1.6.4 Oct 2, 2023
@Dieken
Copy link
Contributor Author

Dieken commented Oct 2, 2023

Fixed #49 #50 #51.

@shiyuhang0
Copy link
Member

@Dieken Can you fix the fmt by pip3 install black black .

Actually this should work for dbt-core>=1.4.0 but I didn't test against old
verions of dbt-core.

Tested against Python 3.8 and 3.11, TiDB 6.5.5.

See dbt-labs/dbt-core#6624

    XxxException -> DbtXxxError
    raise_compiler_error -> CompilationError
@Dieken
Copy link
Contributor Author

Dieken commented Dec 12, 2023

@Dieken Can you fix the fmt by pip3 install black black .

Sure, done.

@shiyuhang0
Copy link
Member

shiyuhang0 commented Dec 13, 2023

Thanks for your contribution!

@shiyuhang0 shiyuhang0 merged commit 14e657d into pingcap:main Dec 13, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants