Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

grpc has a message limit, so long error message can't be received by dmctl #1478

Closed
lance6716 opened this issue Mar 4, 2021 · 2 comments · Fixed by #1610 or #1624
Closed

grpc has a message limit, so long error message can't be received by dmctl #1478

lance6716 opened this issue Mar 4, 2021 · 2 comments · Fixed by #1610 or #1624
Labels
affected-v2.0.2 this issue/BUG affects v2.0.2 affected-v2.0.3 this issue/BUG affects v2.0.3 severity/minor type/bug This issue is a bug report

Comments

@lance6716
Copy link
Collaborator

Feature Request

Is your feature request related to a problem? Please describe:

some grpc requests may reach the limit, so we might backoff some options like https://pkg.go.dev/google.golang.org/grpc#MaxCallRecvMsgSize, or warn the user to split the input (most of time it's a big task.yaml)

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@lance6716
Copy link
Collaborator Author

update: it's more likely that response contains a large error message so reach the recv limit

@lance6716
Copy link
Collaborator Author

caused by precheck generating a long error message

@lance6716 lance6716 changed the title grpc has a message limit grpc has a message limit, so long error message can't be received by dmctl Apr 7, 2021
@lance6716 lance6716 added severity/minor type/bug This issue is a bug report affected-v2.0.2 this issue/BUG affects v2.0.2 labels Apr 7, 2021
@lance6716 lance6716 reopened this Apr 27, 2021
@lance6716 lance6716 added the affected-v2.0.3 this issue/BUG affects v2.0.3 label May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affected-v2.0.2 this issue/BUG affects v2.0.2 affected-v2.0.3 this issue/BUG affects v2.0.3 severity/minor type/bug This issue is a bug report
Projects
None yet
1 participant