Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: limit checker error at a finer granularity and auto increase max size (#1624) #1688

Merged
merged 6 commits into from
May 14, 2021
Merged

*: limit checker error at a finer granularity and auto increase max size (#1624) #1688

merged 6 commits into from
May 14, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1624

What problem does this PR solve?

close #1478

What is changed and how it works?

  • when RPC returned grpc: received message larger than max (5242885 vs. 4194304), increase max message size and retry
  • update dependency to limit the warn/error count at a finer granularity, and pretty print precheck errors

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2021
Merged
@ti-chi-bot ti-chi-bot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/L type/cherry-pick-for-release-2.0 labels May 13, 2021
@ti-chi-bot ti-chi-bot requested review from glorv and GMHDBJD May 13, 2021 08:24
@ti-chi-bot ti-chi-bot requested review from lance6716 and lichunzhu May 13, 2021 08:24
GMHDBJD
GMHDBJD approved these changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 14, 2021
@lance6716
Copy link
Collaborator

/lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels May 14, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a1befb9

@ti-chi-bot ti-chi-bot merged commit 3fbe33b into pingcap:release-2.0 May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@glorv glorv Awaiting requested review from glorv

@lance6716 lance6716 Awaiting requested review from lance6716

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees

@lance6716 lance6716

Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/L status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick-for-release-2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @lance6716 @GMHDBJD