Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

build DM failed if GOPATH is not set #393

Closed
siddontang opened this issue Dec 3, 2019 · 3 comments
Closed

build DM failed if GOPATH is not set #393

siddontang opened this issue Dec 3, 2019 · 3 comments
Assignees
@csuzhangxc
Labels
question This issue is a question type/bug This issue is a bug report

Comments

@siddontang
Copy link
Member

Question

After Go 1.2, it is not necessary to set GOPATH, but if there is not GOPATH, the DM build will fail.

Maybe we should check GOPATH is set before building, another alternative way is to only do the check in CI, or in Dev mod.

make build
gofmt (simplify)
GO111MODULE=off go get golang.org/x/lint/golint
golint
bash: golint: command not found
make: *** [lint] Error 127
@siddontang siddontang added question This issue is a question type/bug This issue is a bug report labels Dec 3, 2019
@IANTHEREAL IANTHEREAL assigned csuzhangxc and unassigned IANTHEREAL Dec 3, 2019
@IANTHEREAL
Copy link
Collaborator

@csuzhangxc PTAL

@csuzhangxc
Copy link
Member

I can fix this later.

@csuzhangxc
Copy link
Member

fixed in #446

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@csuzhangxc csuzhangxc

Labels
question This issue is a question type/bug This issue is a bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@siddontang @csuzhangxc @IANTHEREAL