Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

track tool dependencies in the repo #446

Merged
merged 12 commits into from
Jan 6, 2020
Merged

track tool dependencies in the repo #446

merged 12 commits into from
Jan 6, 2020

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Jan 4, 2020 •
edited
Loading

What problem does this PR solve?

see #445

What is changed and how it works?

  • use retool to track executables written in Go
  • use go.mod to track source code dependencies (including retool)
  • re-generate proto file with dependencies in go.mod

Check List

Tests

  • Unit test
  • Integration test

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/WIP This PR is still work in progress type/dependencies Pull requests that update a dependency file labels Jan 4, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4bdce00). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #446   +/-   ##
===========================================
  Coverage          ?   57.5168%           
===========================================
  Files             ?        166           
  Lines             ?      17035           
  Branches          ?          0           
===========================================
  Hits              ?       9798           
  Misses            ?       6278           
  Partials          ?        959

@csuzhangxc csuzhangxc added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Jan 4, 2020
@csuzhangxc
Copy link
Member Author

@WangXiangUSTC @lichunzhu PTAL

@lichunzhu
Copy link
Contributor

LGTM

@lichunzhu lichunzhu added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jan 5, 2020
WangXiangUSTC
WangXiangUSTC approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jan 6, 2020
@csuzhangxc csuzhangxc merged commit 0c81f89 into pingcap:master Jan 6, 2020
@csuzhangxc csuzhangxc deleted the track-tool branch January 6, 2020 07:48
@csuzhangxc csuzhangxc mentioned this pull request Jan 6, 2020
Closed
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@csuzhangxc
track tool dependencies in the repo (pingcap#446)
a7257dc
@csuzhangxc csuzhangxc mentioned this pull request Jun 18, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csuzhangxc @lichunzhu @WangXiangUSTC