Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

track tool dependencies in the repo #752

Merged
merged 1 commit into from
Jun 18, 2020
Merged

track tool dependencies in the repo #752

merged 1 commit into from
Jun 18, 2020

Conversation

csuzhangxc
Copy link
Member

What problem does this PR solve?

track tool dependencies for release-1.0 as we did in #446

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change

Side effects

  • Possible performance regression
  • Breaking backward compatibility

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes dependencies Pull requests that update a dependency file labels Jun 18, 2020
@csuzhangxc csuzhangxc added this to the v1.0.7 milestone Jun 18, 2020
@csuzhangxc
Copy link
Member Author

/run-all-tests tidb=v4.0.0

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #752 into release-1.0 will increase coverage by 0.5314%.
The diff coverage is 74.0991%.

@@                 Coverage Diff                 @@
##           release-1.0       #752        +/-   ##
===================================================
+ Coverage      57.2665%   57.7980%   +0.5314%     
===================================================
  Files              161        167         +6     
  Lines            16741      16594       -147     
===================================================
+ Hits              9587       9591         +4     
+ Misses            6206       6130        -76     
+ Partials           948        873        -75

WangXiangUSTC
WangXiangUSTC reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 18, 2020
GMHDBJD
GMHDBJD approved these changes Jun 18, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 18, 2020
@csuzhangxc csuzhangxc merged commit 33c7ede into pingcap:release-1.0 Jun 18, 2020
@csuzhangxc csuzhangxc deleted the retool-1.0 branch June 18, 2020 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
v1.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@csuzhangxc @WangXiangUSTC @GMHDBJD