-
Notifications
You must be signed in to change notification settings - Fork 188
binlog, relay: support binlog sequence number larger than 999999 #1476
Conversation
I'll find a way to do an integration test 😵 |
need adjust |
/run-all-tests |
we could inspect docker mount path and modify binlog files. will add integration test later https://dev.mysql.com/doc/refman/5.7/en/docker-mysql-more-topics.html |
oh, you can even build a special MySQL docker image with pre-generated binlog files. |
/cc @GMHDBJD @lichunzhu |
.github/workflows/binlog-999999.yml
Outdated
uses: actions/upload-artifact@v2 | ||
if: ${{ always() }} | ||
with: | ||
name: upstream-switch-logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change name
@@ -49,3 +49,5 @@ require ( | |||
) | |||
|
|||
go 1.13 | |||
|
|||
replace github.com/siddontang/go-mysql v1.1.1-0.20200824131207-0c5789dd0bd3 => github.com/lance6716/go-mysql v1.1.1-0.20210303100354-b0e44c2c5623 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the pr merged to go-mysql?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/siddontang/go-mysql is not maintained now. maybe we could give a hand after finishing our works 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
networks: | ||
db-networks: | ||
ipv4_address: 172.28.128.5 | ||
image: mysql:5.7.32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change to 8.0?
/lgtm |
ping @GMHDBJD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/merge |
@lance6716 Oops! This PR requires at least 2 LGTMs to merge. The current number of |
/merge |
@lance6716 Oops! This PR requires at least 2 LGTMs to merge. The current number of |
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-2.0 in PR #1503 |
What problem does this PR solve?
close #1475
What is changed and how it works?
compare by numeric logic, not byte order
Check List
Tests
Code changes
Side effects
Related changes