This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
loader: don't use ANSI_QUOTES for dumped data files #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
added
needs-cherry-pick-release-2.0
lance6716
force-pushed
the
fix-shard-ansiquote
branch
from
fb35439 to
c8d15e1
Compare
|
/lgtm |
ti-srebot
pushed a commit
to ti-srebot/dm
that referenced
this pull request
Mar 10, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-2.0 in PR #1498 |
ti-srebot
added
already-cherry-pick-2.0
lance6716
pushed a commit
that referenced
this pull request
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
in #1309, condition branch of dumped data file is not tested because of column-mapping, and it has a BUG
What is changed and how it works?
don't use ANSI_QUOTES for dumped data files
Check List
Tests
Related changes