Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: remove improper ignored error (#1585) #1599

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Apr 15, 2021

cherry-pick #1585 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1599

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/dm.git pr/1599:release-2.0-89e7399f2500

What problem does this PR solve?

close #1392

What is changed and how it works?

3 errors should not be ignored: ErrDatabaseNotExists, ErrTableNotExists, ErrColumnNotExists. These errors are not caused by re-execute DDL.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/S type/cherry-pick This PR is just a cherry-pick (backport) labels Apr 15, 2021
@ti-srebot ti-srebot requested review from 3pointer and GMHDBJD April 15, 2021 11:17
@ti-chi-bot ti-chi-bot requested a review from 5kbpers April 15, 2021 11:17
@lance6716
Copy link
Collaborator

/run-all-tests

@lance6716
Copy link
Collaborator

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Apr 16, 2021
@lance6716 lance6716 added the require-LGT1 for small PR, LGT1 is enough label Apr 16, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6dce61d

@ti-chi-bot ti-chi-bot merged commit 6ea9735 into pingcap:release-2.0 Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/S status/can-merge status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants