Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: only get master status once when query-status (#1619) #1630

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

ti-srebot
Copy link

@ti-srebot ti-srebot commented Apr 25, 2021

cherry-pick #1619 to release-2.0
You can switch your code base to this Pull Request by using git-extras:

# In dm repo:
git pr https://github.com/pingcap/dm/pull/1630

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/dm.git pr/1630:release-2.0-defac4af9192

What problem does this PR solve?

originally we get master status in every sync and relay unit, which is redundant because a worker handles only one source

What is changed and how it works?

get master status at worker level

Check List

Tests

  • Pass original tests

Code changes

  • Has interface methods change

Related changes

  • Need to cherry-pick to the release branch

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@lance6716
Copy link
Collaborator

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Apr 26, 2021
@lance6716 lance6716 added the require-LGT1 for small PR, LGT1 is enough label Apr 26, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 487b65c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor require-LGT1 for small PR, LGT1 is enough size/XL status/can-merge status/LGT1 One reviewer already commented LGTM type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants