Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: save empty SQL when online DDL is filtered (#1659) #1668

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1659

What problem does this PR solve?

close #1656

What is changed and how it works?

  • save an empty SQL when online DDL is filtered, and remove it when read it from online DDL component
  • use ? not fmt.Sprintf to build a query

Check List

Tests

  • Integration test

Code changes

  • Has persistent data change (not likely, because if there's quote in source-id, an error already occurred)

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot added needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/L type/cherry-pick-for-release-2.0 labels May 10, 2021
@ti-chi-bot ti-chi-bot requested a review from kennytm May 10, 2021 07:47
@ti-chi-bot ti-chi-bot requested review from 3pointer and GMHDBJD May 10, 2021 07:47
@lichunzhu
Copy link
Contributor

/run-compatibility-test

@lichunzhu
Copy link
Contributor

/run-all-tests

@lichunzhu lichunzhu added the require-LGT1 for small PR, LGT1 is enough label May 10, 2021
@lichunzhu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label May 10, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 7f028bf

@ti-chi-bot ti-chi-bot merged commit fcf9adf into pingcap:release-2.0 May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated require-LGT1 for small PR, LGT1 is enough size/L status/can-merge status/LGT1 One reviewer already commented LGTM type/cherry-pick-for-release-2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants