Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

tracker: change tidb_enable_change_column_type default value to ON (#1821) #1843

Merged
merged 10 commits into from
Jul 7, 2021
Merged

tracker: change tidb_enable_change_column_type default value to ON (#1821) #1843

merged 10 commits into from
Jul 7, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1821

What problem does this PR solve?

close #1769

What is changed and how it works?

as title

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • tracker's defaultGlobalVars change

Side effects

  • allow change dll colum type

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 7, 2021
Merged
@ti-chi-bot ti-chi-bot added needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated size/XL status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0 labels Jul 7, 2021
@ti-chi-bot ti-chi-bot requested review from GMHDBJD and lichunzhu July 7, 2021 02:20
@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jul 7, 2021
lichunzhu
lichunzhu approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 7, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 6e87e9f

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Collaborator

/run-all-tests

1 similar comment
@lance6716
Copy link
Collaborator

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 3a293b2 into pingcap:release-2.0 Jul 7, 2021
@Ehco1996 Ehco1996 removed the needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated label Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@lance6716 lance6716 lance6716 approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees

@Ehco1996 Ehco1996

Labels
size/XL status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @lichunzhu @lance6716 @Ehco1996