Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

.*: fix etcd txn limit for lots of sources #1852

Merged
merged 9 commits into from
Jul 14, 2021
Merged

.*: fix etcd txn limit for lots of sources #1852

merged 9 commits into from
Jul 14, 2021

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jul 9, 2021

What problem does this PR solve?

close #1835 #1804

What is changed and how it works?

  • increase etcd max-txn-ops to 2048
  • expose max-txn-ops and MaxRequestBytes config
  • fix watch goroutine leak, which causes master OOM if upgrade failed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

@ti-chi-bot ti-chi-bot requested review from lance6716 and lichunzhu July 9, 2021 08:31
@GMHDBJD GMHDBJD added type/bug-fix Bug fix needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 status/WIP This PR is still work in progress needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Jul 9, 2021
@ti-chi-bot ti-chi-bot added size/L and removed size/M labels Jul 13, 2021
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jul 13, 2021

/run-all-tests

@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes and removed status/WIP This PR is still work in progress labels Jul 13, 2021
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jul 14, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Jul 14, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 14, 2021
@glorv
Copy link
Collaborator

glorv commented Jul 14, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e5fdc07

@ti-chi-bot ti-chi-bot merged commit 8089f1a into pingcap:master Jul 14, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1868.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 14, 2021
Merged
ti-chi-bot added a commit that referenced this pull request Jul 14, 2021
@ti-chi-bot
.*: fix etcd txn limit for lots of sources (#1852) (#1868)
78b3721
@lance6716 lance6716 mentioned this pull request Jul 27, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@glorv glorv glorv approved these changes

@lance6716 lance6716 lance6716 approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated size/L status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM-master OOM after upgrade failed
4 participants
@GMHDBJD @ti-chi-bot @glorv @lance6716