This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
debug-tools: Binlog event blackhole #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
priority/normal
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
===========================================
Coverage 57.4825% 57.4825%
===========================================
Files 160 160
Lines 16191 16191
===========================================
Hits 9307 9307
Misses 5970 5970
Partials 914 914 |
IANTHEREAL
reviewed
Nov 13, 2019
| When exiting, the result will be output to the log as following | ||
|
|
||
| ```log | ||
| [2019/08/12 15:44:19.269 +08:00] [INFO] [main.go:95] ["binlog-event-blackhole exit"] [event-count=35] [byte-count=2360] [duration=705.627314ms] [tps=49.601254522865595] ["speed (byte/s)"=3344.541733541794] |
There was a problem hiding this comment.
Suggested change
| [2019/08/12 15:44:19.269 +08:00] [INFO] [main.go:95] ["binlog-event-blackhole exit"] [event-count=35] [byte-count=2360] [duration=705.627314ms] [tps=49.601254522865595] ["speed (byte/s)"=3344.541733541794] | |
| [2019/08/12 15:44:19.269 +08:00] [INFO] [main.go:95] ["binlog-event-blackhole exit"] [event-count=35] [byte-count=2360] [duration=705.627314ms] [tps=49.601254522865595] ["throughput (byte/s)"=3344.541733541794] |
IANTHEREAL
reviewed
Nov 13, 2019
| | byte-count | The total bytes have received from the upstream master | | ||
| | duration | The duration has be taken to fetch binlog events | | ||
| | tps | The events have received per second | | ||
| | speed | The speed of fetching binlog event data (bytes/second) | |
There was a problem hiding this comment.
Suggested change
| | speed | The speed of fetching binlog event data (bytes/second) | | |
| | throughput | The throughput of fetching binlog event data (bytes/second) | |
IANTHEREAL
reviewed
Nov 13, 2019
| } | ||
|
|
||
| // readEventsWithGoMySQL reads binlog events from the master server with `go-mysql` pkg. | ||
| func readEventsWithGoMySQL(ctx context.Context, conn *client.Conn) (uint64, uint64, time.Duration, error) { |
There was a problem hiding this comment.
the differences with readEventsWithoutGoMySQL is the "github.com/siddontang/go-mysql/client".Conn use a buffer, I originally thought that it also contains more logic, such as decoding/parsing.
Let's do this now, you can add the complete go-mysql logic later.
There was a problem hiding this comment.
Yeh. after doing some benchmark later, I think more (fine-grained) things we can do.
IANTHEREAL
reviewed
Nov 13, 2019
| speed := float64(byteCount) / duration.Seconds() | ||
| log.L().Info("binlog-event-blackhole exit", | ||
| zap.Uint64("event-count", eventCount), zap.Uint64("byte-count", byteCount), | ||
| zap.Duration("duration", duration), zap.Float64("tps", tps), zap.Float64("speed (byte/s)", speed)) |
There was a problem hiding this comment.
Suggested change
| zap.Duration("duration", duration), zap.Float64("tps", tps), zap.Float64("speed (byte/s)", speed)) | |
| zap.Duration("duration", duration), zap.Float64("tps", tps), zap.Float64("throughput (byte/s)", speed)) |
There was a problem hiding this comment.
addressed in 50c2b56.
|
Rest LGTM |
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
IANTHEREAL
added
status/LGT1
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
1 similar comment
|
/run-all-tests tidb=release-3.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add a binlog-event-blackhole tool to test the speed of fetching binlog event.
What is changed and how it works?
add a binlog-event-blackhole tool.
Check List
Tests
for more information, see README.md under the binlog-event-blackhole folder.