This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
dm-worker: split DDL sync from sync function #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
===========================================
Coverage 60.0717% 60.0717%
===========================================
Files 134 134
Lines 14769 14769
===========================================
Hits 8872 8872
Misses 5054 5054
Partials 843 843 |
@amyangfei @csuzhangxc PTAL |
amyangfei
reviewed
Sep 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
csuzhangxc
reviewed
Sep 18, 2019
csuzhangxc
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3pointer
added a commit
to 3pointer/dm
that referenced
this pull request
Sep 23, 2019
* split DDL sync from sync function
3pointer
added a commit
that referenced
this pull request
Sep 23, 2019
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
* split DDL sync from sync function
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-cherry-pick-1.0
The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked
priority/unimportant
Really minor change, requires approval from secondary reviewers
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/enhancement
Performance improvement or refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Optimize sync function
What is changed and how it works?
Split sync DDL from
sync()
because sync DDL and sync DML don't have to many common logic.Split them to make the code clear.
Check List
Tests
Code changes
Side effects
Related changes
dm/dm-ansible