Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dm-worker: split DDL sync from sync function #289

Merged
merged 4 commits into from
Sep 23, 2019

Conversation

3pointer
Copy link
Contributor

What problem does this PR solve?

Optimize sync function

What is changed and how it works?

Split sync DDL from sync() because sync DDL and sync DML don't have to many common logic.
Split them to make the code clear.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the dm/dm-ansible
  • Need to be included in the release note

@3pointer 3pointer added priority/unimportant Really minor change, requires approval from secondary reviewers status/PTAL This PR is ready for review. Add this label back after committing new changes type/enhancement Performance improvement or refactoring needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Sep 17, 2019
@3pointer 3pointer self-assigned this Sep 17, 2019
@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #289 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #289   +/-   ##
===========================================
  Coverage   60.0717%   60.0717%           
===========================================
  Files           134        134           
  Lines         14769      14769           
===========================================
  Hits           8872       8872           
  Misses         5054       5054           
  Partials        843        843

@csuzhangxc
Copy link
Member

@amyangfei @csuzhangxc PTAL

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 17, 2019
syncer/syncer.go Outdated Show resolved Hide resolved
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 19, 2019
@3pointer 3pointer merged commit 888c254 into pingcap:master Sep 23, 2019
3pointer added a commit to 3pointer/dm that referenced this pull request Sep 23, 2019
3pointer added a commit that referenced this pull request Sep 23, 2019
@3pointer 3pointer added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Sep 23, 2019
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/enhancement Performance improvement or refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants