This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
DM-worker: add error abstraction in pb.ProcessError #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
priority/normal
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
===========================================
Coverage 60.8069% 60.8069%
===========================================
Files 134 134
Lines 15615 15615
===========================================
Hits 9495 9495
Misses 5208 5208
Partials 912 912 |
amyangfei
added
the
status/PTAL
|
/run-compatibility-test |
|
/run-compatibility-test pre_commit=ce5e03815c28789877c6941e98da2161a2dd1dbb |
amyangfei
added
the
priority/release-blocker
csuzhangxc
added
status/LGT1
dm/worker/subtask.go
Outdated
Comment on lines
378
to
384
| result := proto.Clone(st.result).(*pb.ProcessResult) | ||
| if result != nil { | ||
| for i := range result.Errors { | ||
| result.Errors[i].Error = nil | ||
| } | ||
| } | ||
| return result |
There was a problem hiding this comment.
these code is same with realRelayHolder.Result(), how about define a funcion to do this?
|
LGTM |
WangXiangUSTC
added
status/LGT2
WangXiangUSTC
approved these changes
Oct 17, 2019
|
cherry pick to release-1.0 failed |
amyangfei
added a commit
to amyangfei/dm
that referenced
this pull request
Oct 17, 2019
amyangfei
added a commit
that referenced
this pull request
Oct 17, 2019
amyangfei
added
already-cherry-pick-1.0
Merged
csuzhangxc
added
already-update-release-note
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently we use
pb.ProcessErrorto pass error information among different components on the wire through gRPC, but the information includes error type and error message only, which is not very compatible with DM new error system.What is changed and how it works?
Add more fields into
pb.ProcessErrorand make it possible to reconstruct a*terror.Errorobject frompb.ProcessErrorCheck List
Tests
Code changes
Side effects
Related changes