This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
checker: increase total timeout to 30m; set readTimeout for DB check operation to 30s #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
priority/normal
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
===============================================
+ Coverage 59.5074% 59.9455% +0.438%
===============================================
Files 135 135
Lines 15267 15047 -220
===============================================
- Hits 9085 9020 -65
+ Misses 5301 5151 -150
+ Partials 881 876 -5 |
|
@WangXiangUSTC @lichunzhu PTAL |
lichunzhu
added
status/LGT1
checker/checker.go
Outdated
| @@ -125,7 +126,9 @@ func (c *Checker) Init() (err error) { | |||
| User: instance.cfg.From.User, | |||
| Password: instance.cfg.From.Password, | |||
| } | |||
| instance.sourceDB, err = dbutil.OpenDB(*instance.sourceDBinfo) | |||
| dbCfg := instance.cfg.From | |||
| dbCfg.RawDBCfg = config.DefaultRawDBConfig().SetReadTimeout("30s") | |||
There was a problem hiding this comment.
how about define a const value for 30s and 30*time.Minute?
There was a problem hiding this comment.
instance is a pointer, we need make sure it will not do influence to others if we SetReadTimeout here
There was a problem hiding this comment.
instance only used for checking and I want all operation in checking affected by this readTime.
BTW, instance.cfg.From is a value.
There was a problem hiding this comment.
how about define a const value for
30sand30*time.Minute?
addressed in c72263d.
There was a problem hiding this comment.
30s not define as a value
WangXiangUSTC
added
status/LGT2
|
cherry pick to release-1.0 in PR #327 |
sre-bot
added
the
already-cherry-pick-1.0
sre-bot
removed
the
needs-cherry-pick-release-1.0
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
…operation to 30s (pingcap#315)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If a mass of tables in one task, the check operation may not be complete in 1 minute.
What is changed and how it works?
readTimeoutfor DB operation to 30sCheck List
Tests
Related changes