This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
priority/important
Major change, requires approval from ≥2 primary reviewers
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
status/WIP
This PR is still work in progress
type/feature
New feature
type/feature-request
This issue is a feature request
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
should-update-dm-ansible
labels
Nov 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
================================================
- Coverage 57.6502% 57.6476% -0.0027%
================================================
Files 159 159
Lines 16019 16018 -1
================================================
- Hits 9235 9234 -1
Misses 5884 5884
Partials 900 900 |
csuzhangxc
added
status/PTAL
This PR is ready for review. Add this label back after committing new changes
and removed
status/WIP
This PR is still work in progress
labels
Nov 6, 2019
csuzhangxc
requested review from
amyangfei and
WangXiangUSTC
and removed request for
amyangfei
November 6, 2019 02:41
@WangXiangUSTC @amyangfei PTAL |
/run-all-tests |
1 similar comment
/run-all-tests |
some users deploy dm-master and more than one dm-worker in one server, perhaps they use port like 8261, 8262, 8263 ... |
/run-all-tests |
WangXiangUSTC
added
status/LGT1
One reviewer already commented LGTM
and removed
status/PTAL
This PR is ready for review. Add this label back after committing new changes
labels
Nov 12, 2019
LGTM |
@amyangfei PTAL. we are adding another integration test case |
amyangfei
reviewed
Nov 12, 2019
amyangfei
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amyangfei
added
status/LGT2
Two reviewers already commented LGTM, ready for merge
and removed
status/LGT1
One reviewer already commented LGTM
labels
Nov 12, 2019
/run-all-tests |
3 similar comments
/run-all-tests |
/run-all-tests |
/run-all-tests |
csuzhangxc
added
the
type/compatibility
Backward compatibility will be broken after this PR merged
label
Nov 20, 2019
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
csuzhangxc
removed
needs-update-dm-ansible
needs-update-docs
Should update docs after this PR is merged. Remove this label once the docs are updated
needs-update-release-note
This PR should be added into release notes. Remove this label once the release notes are updated
labels
Jun 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority/important
Major change, requires approval from ≥2 primary reviewers
status/LGT2
Two reviewers already commented LGTM, ready for merge
type/compatibility
Backward compatibility will be broken after this PR merged
type/feature
New feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
embed etcd in DM-master.
What is changed and how it works?
name
: human-readable name for this DM-master member (default 'dm-master-${hostname}')data-dir
: path to the data directory (default 'default.${name}')initial-cluster
: initial cluster configuration for bootstrapping, e,g. 'dm-master=http://127.0.0.1:8291'peer-urls
: URLs for peer traffic (default 'http://127.0.0.1:8291')advertise-peer-urls
: advertise URLs for peer traffic (default '${peer-urls}')NOTE: we use
master-addr
to generatelisten-client-urls
andadvertise-client-urls
now.to reviewers:
8261
for clients request, now another port is needed for peers request. I use8291
as the default peer port, do you think is it OK?tidb
andtidb-tool
upgradedCheck List
Tests
Code changes
Side effects
Related changes
dm/dm-ansible