This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
dm-ansible: don't add config in config file if not setted in inventory.ini #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangXiangUSTC
added
status/PTAL
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
================================================
+ Coverage 57.6128% 57.6605% +0.0477%
================================================
Files 159 158 -1
Lines 16019 15978 -41
================================================
- Hits 9229 9213 -16
+ Misses 5887 5867 -20
+ Partials 903 898 -5 |
csuzhangxc
added
status/LGT2
|
cherry pick to release-1.0 in PR #347 |
sre-bot
added
already-cherry-pick-1.0
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
server-id, flavor, relay-binlog-name and relay-binlog-gtid is not necessary any more, so user may not set in inventory.ini when use ansible to deploy, but now it will return error "AnsibleUndefinedVariable: 'server_id' is undefined"
test
manual test
What is changed and how it works?
don't add config in config file if not setted in inventory.ini
Related changes