This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: fix DB connection close and all_mode integration test #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
priority/unimportant
|
/run-all-tests tidb=release-3.0 |
1 similar comment
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-2.1 |
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
===============================================
+ Coverage 56.2905% 57.492% +1.2014%
===============================================
Files 166 165 -1
Lines 17248 16898 -350
===============================================
+ Hits 9709 9715 +6
+ Misses 6585 6231 -354
+ Partials 954 952 -2 |
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
csuzhangxc
changed the title
|
@3pointer @amyangfei PTAL |
amyangfei
added
status/LGT1
3pointer
approved these changes
Dec 17, 2019
3pointer
added
the
status/LGT2
|
cherry pick to release-1.0 in PR #435 |
sre-bot
added
already-cherry-pick-1.0
csuzhangxc
added
the
needs-update-release-note
csuzhangxc
added a commit
to csuzhangxc/dm
that referenced
this pull request
Dec 17, 2019
(cherry picked from commit 6612cf7)
csuzhangxc
added a commit
that referenced
this pull request
Dec 18, 2019
glorv
pushed a commit
to glorv/dm
that referenced
this pull request
Dec 25, 2019
csuzhangxc
added
already-update-release-note
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
resume-taskmay fail becauseresetBaseConnFnreturning an invalid existing connection/tmp/dm_test/all_mode/worker1/log/dm-worker.log dosen't contain dispatch auto resume task.What is changed and how it works?
Check List
Tests
Related changes