This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
HA: add advertise-addr for DM-worker
#450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
priority/normal
…rtise # Conflicts: # tests/_utils/run_dm_worker
|
/run-all-tests tidb=release-3.0 |
csuzhangxc
added
status/LGT1
|
@WangXiangUSTC @lichunzhu PTAL |
csuzhangxc
changed the title
advertise-addr for DM-workeradvertise-addr for DM-worker
| @@ -25,7 +25,7 @@ PWD=$(pwd) | |||
| echo "[$(date)] <<<<<< START DM-WORKER on port $port, config: $conf >>>>>>" | |||
| cd $workdir | |||
| $binary -test.coverprofile="$TEST_DIR/cov.$TEST_NAME.worker.$port.$(date +"%s").out" DEVEL \ | |||
| --worker-addr=:$port \ | |||
| --worker-addr=0.0.0.0:$port \ | |||
There was a problem hiding this comment.
do we need to check the host? 0.0.0.0:$port will become the advertise-addr, but it can not be used by dm-master
There was a problem hiding this comment.
👍 addressed in 2024c7c.
- add the check for
0.0.0.0as theadvertise-addr - add
advertise-addrwhen running dm-worker in tests.
|
/run-all-tests tidb=release-3.0 |
|
LGTM |
WangXiangUSTC
added
status/LGT1
|
There same to be some problem with |
|
/run-all-tests tidb=release-3.0 |
Yes, the problem was introduced when merging changes from for other PR, and I've updated in d6f8084. |
lichunzhu
added
status/LGT2
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
csuzhangxc
added
already-update-docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
DM-worker may listen on some special address (like
0.0.0.0:8262) in a k8s pod, when registering it into the DM-master cluster, the DM-master may not access it with this special address.What is changed and how it works?
advertise-addrconfig item for DM-worker to handle client traffic.Check List
Tests
Code changes
Related changes
dm/dm-ansible