Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

syncer: fix lock in streamer controller(#470) #472

Merged
merged 1 commit into from
Feb 10, 2020
Merged

syncer: fix lock in streamer controller(#470) #472

merged 1 commit into from
Feb 10, 2020

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

  1. GetEvent may cost too many time, and will lock the StreamerController, need refine it
  2. both Start and Close have lock, but when Start failed will call the Close function, need fix the dead lock

What is changed and how it works?

cherry-pick from #470 and resolve conflicts

Check List

Tests

  • Manual test

@WangXiangUSTC WangXiangUSTC added priority/normal Minor change, requires approval from ≥1 primary reviewer type/cherry-pick This PR is just a cherry-pick (backport) labels Feb 10, 2020
@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb=release-3.0

@WangXiangUSTC
Copy link
Contributor Author

@lichunzhu @csuzhangxc PTAL

lichunzhu
lichunzhu reviewed Feb 10, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu added the status/LGT1 One reviewer already commented LGTM label Feb 10, 2020
csuzhangxc
csuzhangxc approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Feb 10, 2020
@WangXiangUSTC WangXiangUSTC merged commit 7135428 into ha-dev Feb 10, 2020
@WangXiangUSTC WangXiangUSTC deleted the xiang/pick_streamer branch February 10, 2020 05:46
lichunzhu pushed a commit to lichunzhu/dm that referenced this pull request Apr 6, 2020
@WangXiangUSTC
syncer: fix lock in streamer controller (pingcap#472)
fe1073c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WangXiangUSTC @csuzhangxc @lichunzhu