This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
dm/master, dm/worker: handle etcd retryable errors for watcher #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
added
the
priority/normal
|
/run-all-tests tidb=release-3.0 |
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
===========================================
Coverage 56.2980% 56.2980%
===========================================
Files 184 184
Lines 18585 18585
===========================================
Hits 10463 10463
Misses 7072 7072
Partials 1050 1050 |
lichunzhu
added
status/PTAL
csuzhangxc
reviewed
Mar 2, 2020
| s.handleWorkerEv(ctx, workerEvCh, workerErrCh) | ||
| }() | ||
| // starting to observe status of DM-worker instances. | ||
| s.observeWorkerEvent(ctx, etcdCli, rev1) |
There was a problem hiding this comment.
Do we need to handle the returned error for observeWorkerEvent? (or add a TODO for later handling, like retire from the leader...)
There was a problem hiding this comment.
I prefer to add a TODO here. Now s.observeWorkerEvent will not return other error because we don't return error in s.handleWorkerEvent. This can be done after we classify the retryable errors and fatal errors.
|
/run-all-tests tidb=release-3.0 |
1 similar comment
|
/run-all-tests tidb=release-3.0 |
csuzhangxc
reviewed
Mar 2, 2020
| return nil | ||
| case <-time.After(500 * time.Millisecond): | ||
| rev, err = s.resetWorkerEv(etcdCli) | ||
| if err != nil { |
There was a problem hiding this comment.
Do we need to check this err is retryable here?
There was a problem hiding this comment.
I think all the errors are retryable here.
There was a problem hiding this comment.
including errors returned from ha.GetKeepAliveWorkers?
There was a problem hiding this comment.
Yes. Maybe we don't run ha.GetKeepAliveWorkers successfully now, but we may succeed in the future.
csuzhangxc
reviewed
Mar 2, 2020
|
/run-all-tests tidb=release-3.0 |
csuzhangxc
reviewed
Mar 2, 2020
lichunzhu
changed the title
|
/run-all-tests tidb=release-3.0 |
WangXiangUSTC
added
status/LGT1
|
/run-all-tests tidb=release-3.0 |
1 similar comment
|
/run-all-tests tidb=release-3.0 |
csuzhangxc
added
status/LGT2
This was referenced Mar 5, 2020
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
…ap#499) * Rebuild info and restart handle etcd event routine when receiving etcd retryable error (ErrCompacted, ErrNoLeader, ErrNoSpace). * Return resp.Header.Revision even if we don't get value from etcd server.
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
…evision` (pingcap#518) * Reset get error in watcher like we did in pingcap#499. * Get relative etcd info in one etcd transaction to avoid using get with rev.
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
…ap#499) * Rebuild info and restart handle etcd event routine when receiving etcd retryable error (ErrCompacted, ErrNoLeader, ErrNoSpace). * Return resp.Header.Revision even if we don't get value from etcd server.
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
…evision` (pingcap#518) * Reset get error in watcher like we did in pingcap#499. * Get relative etcd info in one etcd transaction to avoid using get with rev.
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 7, 2020
…ap#499) * Rebuild info and restart handle etcd event routine when receiving etcd retryable error (ErrCompacted, ErrNoLeader, ErrNoSpace). * Return resp.Header.Revision even if we don't get value from etcd server.
lichunzhu
added a commit
to lichunzhu/dm
that referenced
this pull request
Apr 7, 2020
…evision` (pingcap#518) * Reset get error in watcher like we did in pingcap#499. * Get relative etcd info in one etcd transaction to avoid using get with rev.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#501
When receiving etcd compaction error from wather, the handle goroutine will lose event if we don't do anything.
What is changed and how it works?
ErrCompacted, ErrNoLeader, ErrNoSpace).resp.Header.Revisioneven if we don't get value from etcd server.Check List
Tests
Side effects
Related changes
dm/dm-ansible