This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
dm-master: fix DM-master can not exit when starting timeout #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csuzhangxc
added
priority/normal
|
/run-all-tests tidb=release-3.0 |
2 similar comments
|
/run-all-tests tidb=release-3.0 |
|
/run-all-tests tidb=release-3.0 |
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
===========================================
Coverage ? 56.3478%
===========================================
Files ? 184
Lines ? 18581
Branches ? 0
===========================================
Hits ? 10470
Misses ? 7060
Partials ? 1051 |
csuzhangxc
added
status/PTAL
|
@WangXiangUSTC @lichunzhu PTAL |
lichunzhu
reviewed
Mar 4, 2020
Co-Authored-By: Chunzhu Li <lichunzhu@pingcap.com>
|
/run-all-tests tidb=release-3.0 |
lichunzhu
added
status/LGT1
|
/run-all-tests tidb=release-3.0 |
|
LGTM |
WangXiangUSTC
added
status/LGT2
|
/run-all-tests tidb=release-3.0 |
1 similar comment
|
/run-all-tests tidb=release-3.0 |
WangXiangUSTC
approved these changes
Mar 4, 2020
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #507
What is changed and how it works?
see comments in dm/master/etcd.go from L61 to L68.
Check List
Tests