Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: support recover relay log file with a subset of metadata (#530) #531

Closed
wants to merge 3 commits into from

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Mar 12, 2020

cherry-pick #530 to release-1.0


What problem does this PR solve?

fix #443 , this should be release under v1.0.4.

What is changed and how it works?

  • support recover relay log file with a subset of metadata

    • check whether the metadata is a subset of the relay log file
  • also update go-mysql to fix GTIDSet.Equal.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change
  • Has persistent data change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@sre-bot sre-bot added priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Mar 12, 2020
@csuzhangxc
Copy link
Member

/run-all-tests tidb=release-3.0

@csuzhangxc csuzhangxc added this to the v1.0.4 milestone Mar 12, 2020
@WangXiangUSTC
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@17a299c). Click here to learn what that means.
The diff coverage is 83.3333%.

@@               Coverage Diff                @@
##             release-1.0       #531   +/-   ##
================================================
  Coverage               ?   57.2707%           
================================================
  Files                  ?        161           
  Lines                  ?      16649           
  Branches               ?          0           
================================================
  Hits                   ?       9535           
  Misses                 ?       6171           
  Partials               ?        943

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added the status/LGT2 Two reviewers already commented LGTM, ready for merge label Mar 12, 2020
@csuzhangxc csuzhangxc closed this Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants