Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

config: support domain:port as well as ip:port #926

Merged
merged 4 commits into from
Aug 26, 2020
Merged

config: support domain:port as well as ip:port #926

merged 4 commits into from
Aug 26, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Aug 25, 2020 •
edited
Loading

What problem does this PR solve?

support domain:port as well as ip:port, originally some URl parse will fail

What is changed and how it works?

modify URL parse and config check

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

@lance6716 lance6716 added the status/WIP This PR is still work in progress label Aug 25, 2020
@lance6716 lance6716 added needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix and removed status/WIP This PR is still work in progress labels Aug 25, 2020
@lance6716
Copy link
Collaborator Author

PTAL @lichunzhu

@lance6716
Copy link
Collaborator Author

/run-all-tests

lichunzhu
lichunzhu approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 26, 2020
csuzhangxc
csuzhangxc approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 26, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.2 milestone Aug 26, 2020
@csuzhangxc csuzhangxc merged commit 6a09c31 into pingcap:master Aug 26, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 26, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #934

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Aug 26, 2020
@lance6716 lance6716 deleted the domain-port branch August 26, 2020 08:35
lance6716 pushed a commit that referenced this pull request Aug 26, 2020
@ti-srebot
config: support domain:port as well as ip:port (#926) (#934)
a3b9548
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0 RC.2
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-srebot @csuzhangxc @lichunzhu