This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
mydumper: pipe mydumper log into dm-worker.log #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
priority/normal
|
PTAL @csuzhangxc |
|
Good Job！ LGTM |
csuzhangxc
added
status/LGT1
csuzhangxc
added
status/LGT2
lichunzhu
pushed a commit
to lichunzhu/dm
that referenced
this pull request
Apr 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #83.
What is changed and how it works?
Instruct mydumper to write log into
/dev/stderr. Then, change dm_worker to read lines from the child process'sstderr, and convert into the correspondinglog.*call.Note, unlike the description of #83, in this PR
mydumper-$task.logis no longer createddm-worker.log, if enabled.Check List
Tests
dm-worker.logwhen runningmake integration_test)Code changes
Side effects
Related changes