Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: run chaos-mesh operations with GitHub action #930

Merged
merged 120 commits into from
Sep 23, 2020
Merged

*: run chaos-mesh operations with GitHub action #930

merged 120 commits into from
Sep 23, 2020

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Aug 25, 2020 •
edited
Loading

What problem does this PR solve?

  • run chaos-mesh operations with GitHub action

What is changed and how it works?

  • add a chaos-mesh GitHub action workflow
  • add a test case with chaos-mesh operations

NOTE：

  • no DDL added in the sample case and should be added later
  • only one source in the sample case and should add more sources and shard merge cases

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@csuzhangxc csuzhangxc added status/WIP This PR is still work in progress type/qa relate to quality assurance needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Aug 25, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 22, 2020
@csuzhangxc
Copy link
Member Author

@lance6716 @GMHDBJD

I did some updates after your review:

  • send Slack message if the test case failed (only to me now)
  • replace KIND with K3s as the K8s cluster for performance and usability
  • add tzdata into the docker image
  • fix selector usage for chaos-mesh (it has different selector with K8s)
  • update logs as artifact before ending the workflow (see a sample in https://github.com/pingcap/dm/actions/runs/266604455)

PTAL again

GMHDBJD
GMHDBJD approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc merged commit 470e902 into master Sep 23, 2020
@csuzhangxc csuzhangxc deleted the chaos-action branch September 23, 2020 02:08
@ti-srebot
Copy link

cherry pick to release-2.0 failed

csuzhangxc added a commit that referenced this pull request Sep 23, 2020
@csuzhangxc
*: run chaos-mesh operations with GitHub action (#930)
5fa21ca
@csuzhangxc csuzhangxc mentioned this pull request Sep 23, 2020
Merged
@csuzhangxc csuzhangxc added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 23, 2020
csuzhangxc added a commit that referenced this pull request Sep 23, 2020
@csuzhangxc
*: run chaos-mesh operations with GitHub action (#930) (#1073)
5ca81da
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes type/qa relate to quality assurance
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@csuzhangxc @lance6716 @ti-srebot @GMHDBJD