Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

shardddl: fix lock not found after try sync #939

Merged
merged 4 commits into from
Aug 28, 2020
Merged

shardddl: fix lock not found after try sync #939

merged 4 commits into from
Aug 28, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Aug 27, 2020

What problem does this PR solve?

close #936

What is changed and how it works?

return lock instead of lockID in TrySync, use this lock if the lock was deleted by others

Check List

Tests

  • hard to test

@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix already-update-release-note The release note is updated. Add this label once the release note is updated needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Aug 27, 2020
@GMHDBJD GMHDBJD mentioned this pull request Aug 27, 2020
Merged
10 tasks
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Aug 27, 2020

/run-all-tests

2 similar comments
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Aug 27, 2020

/run-all-tests

@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Aug 27, 2020

/run-all-tests

@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Aug 28, 2020

/run-all-tests

csuzhangxc
csuzhangxc reviewed Aug 28, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 28, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.2 milestone Aug 28, 2020
@csuzhangxc csuzhangxc requested a review from lance6716 August 28, 2020 04:40
lance6716
lance6716 approved these changes Aug 28, 2020
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT2 Two reviewers already commented LGTM, ready for merge status/LGT1 One reviewer already commented LGTM and removed status/LGT1 One reviewer already commented LGTM status/LGT2 Two reviewers already commented LGTM, ready for merge labels Aug 28, 2020
@GMHDBJD GMHDBJD merged commit a26c718 into pingcap:master Aug 28, 2020
@GMHDBJD GMHDBJD deleted the fixHandleLock branch August 28, 2020 05:23
@ti-srebot ti-srebot mentioned this pull request Aug 28, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #944

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Aug 28, 2020
csuzhangxc pushed a commit that referenced this pull request Aug 28, 2020
@ti-srebot
shardddl: fix lock not found after try sync (#939) (#944)
a358aca
@csuzhangxc csuzhangxc mentioned this pull request Aug 28, 2020
Merged
10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked already-update-release-note The release note is updated. Add this label once the release note is updated status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0 RC.2
Development

Successfully merging this pull request may close these issues.

optimistic shard ddl block in GetOperation
4 participants
@GMHDBJD @ti-srebot @lance6716 @csuzhangxc