Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

config: fix binlog-gtid verify (#983) #987

Merged
merged 3 commits into from
Sep 3, 2020
Merged

config: fix binlog-gtid verify (#983) #987

merged 3 commits into from
Sep 3, 2020

Conversation

ti-srebot
Copy link

cherry-pick #983 to release-2.0

What problem does this PR solve?

fix #978

What is changed and how it works?

check binlog-gtid in Verify.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

@ti-srebot ti-srebot mentioned this pull request Sep 3, 2020
Merged
@ti-srebot ti-srebot added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Sep 3, 2020
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot added the status/LGT1 One reviewer already commented LGTM label Sep 3, 2020
@csuzhangxc csuzhangxc merged commit 18852db into pingcap:release-2.0 Sep 3, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-srebot @lance6716 @csuzhangxc