This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
log: support change the level of etcd for debugging #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
reviewed
Sep 4, 2020
| logger := log.L().WithFields(zap.String("component", "embed etcd")) | ||
| // if logLevel is info, set etcd log level to WARN to reduce log | ||
| if strings.ToLower(logLevel) == "info" { | ||
| logger.Logger = logger.WithOptions(zap.IncreaseLevel(zap.WarnLevel)) |
There was a problem hiding this comment.
let's log this change to tell user. and "debug" maybe a level lower than "info"
There was a problem hiding this comment.
add log in 6d12af4
user can use debug level to see more log about etcd.
| logger.Logger = logger.WithOptions(zap.IncreaseLevel(zap.WarnLevel)) | ||
| } | ||
|
|
||
| cfg.ZapLoggerBuilder = embed.NewZapCoreLoggerBuilder(logger.Logger, logger.Core(), log.Props().Syncer) // use global app props. |
There was a problem hiding this comment.
not sure why change logger to logger.Logger
There was a problem hiding this comment.
type of logger now is log.Logger after
Line 451 in 7de7bb4
lance6716
added
needs-cherry-pick-release-2.0
|
LGTM |
csuzhangxc
added
status/LGT2
|
cherry pick to release-2.0 in PR #995 |
ti-srebot
added
already-cherry-pick-2.0
csuzhangxc
pushed a commit
that referenced
this pull request
Sep 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #974
What is changed and how it works?
warnif log-level isinfo, otherwise set it same as log-levelCheck List
Tests
Manually check the log file.