Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

relay: fix invalid flavor after restart dm-master #994

Merged
merged 4 commits into from
Sep 7, 2020
Merged

relay: fix invalid flavor after restart dm-master #994

merged 4 commits into from
Sep 7, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Sep 4, 2020

What problem does this PR solve?

close #993

What is changed and how it works?

copy source config to subtask task before getMinPosInAllSubTasks

Check List

Tests

@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 4, 2020
@lance6716 lance6716 mentioned this pull request Sep 7, 2020
Merged
14 tasks
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Sep 7, 2020

/run-all-tests

csuzhangxc
csuzhangxc reviewed Sep 7, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/worker/worker.go Show resolved Hide resolved
@csuzhangxc csuzhangxc added this to the v2.0.0 RC.3 milestone Sep 7, 2020
lance6716
lance6716 reviewed Sep 7, 2020
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dm/worker/worker.go Outdated Show resolved Hide resolved
dm/worker/worker.go Outdated Show resolved Hide resolved
GMHDBJD and others added 2 commits September 7, 2020 10:39
@GMHDBJD
remove empty comment
3e07cdd
@GMHDBJD @lance6716
Update dm/worker/worker.go
25598b1 
Co-authored-by: lance6716 <lance6716@gmail.com>
csuzhangxc
csuzhangxc reviewed Sep 7, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Sep 7, 2020
@lance6716
Copy link
Collaborator

LGTM

@lance6716
Copy link
Collaborator

/run-all-tests

@GMHDBJD GMHDBJD merged commit 9753f31 into pingcap:master Sep 7, 2020
@GMHDBJD GMHDBJD deleted the fixInvalidFlavor branch September 7, 2020 03:36
@ti-srebot ti-srebot mentioned this pull request Sep 7, 2020
Merged
@ti-srebot
Copy link

cherry pick to release-2.0 in PR #999

@ti-srebot ti-srebot added already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 labels Sep 7, 2020
GMHDBJD pushed a commit that referenced this pull request Sep 7, 2020
@ti-srebot
relay: fix invalid flavor after restart dm-master (#994) (#999)
21d390f
@ti-srebot ti-srebot mentioned this pull request Sep 7, 2020
Merged
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-2.0 The related PR is already cherry-picked to release-2.0. Add this label once the PR is cherry-picked status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

invalid flavor after restart master
4 participants
@GMHDBJD @lance6716 @ti-srebot @csuzhangxc