Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: prepared plan cache support limit #12686

Merged
merged 11 commits into from
Feb 16, 2023

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Jan 17, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Starting from v6.6, plan cache support supports limit.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 17, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from hfxsd January 17, 2023 02:40
@ti-chi-bot ti-chi-bot added the missing-translation-status This PR does not have translation status info. label Jan 17, 2023
@fzzf678 fzzf678 marked this pull request as draft January 17, 2023 02:40
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 17, 2023
@TomShawn TomShawn requested review from shichun-0415 and qw4990 and removed request for hfxsd January 17, 2023 02:47
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. v6.6 and removed missing-translation-status This PR does not have translation status info. labels Jan 17, 2023
@fzzf678 fzzf678 changed the title planner: prepared plan cache support limit and subquery planner: prepared plan cache support limit Jan 29, 2023
@fzzf678 fzzf678 marked this pull request as ready for review January 29, 2023 06:29
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2023
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 30, 2023
@shichun-0415 shichun-0415 requested a review from Oreoxmt January 30, 2023 09:47
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 30, 2023
@TomShawn
Copy link
Contributor

According to @qw4990, this feature might be postponed. cc @shichun-0415

@shichun-0415
Copy link
Contributor

According to @qw4990, this feature might be postponed. cc @shichun-0415

According to information from @songrijie, it is correct that plan cache supports limit in v6.6. The support for subqueries will be released in future sprints.

system-variables.md Outdated Show resolved Hide resolved
system-variables.md Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review February 1, 2023 06:40
system-variables.md Outdated Show resolved Hide resolved
fzzf678 and others added 2 commits February 1, 2023 14:41
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 1, 2023
@shichun-0415 shichun-0415 added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Feb 3, 2023
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 6, 2023
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
qw4990 and others added 2 commits February 16, 2023 18:56
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>
sql-prepared-plan-cache.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
Co-authored-by: Aolin <aolinz@outlook.com>
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bbf87bf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2023
@ti-chi-bot ti-chi-bot merged commit 8873d10 into pingcap:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants