Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/lightning: update lightning docs #1334

Merged
merged 5 commits into from
May 24, 2019
Merged

tools/lightning: update lightning docs #1334

merged 5 commits into from
May 24, 2019

Conversation

huangxiuyan
Copy link
Contributor

@huangxiuyan huangxiuyan commented May 16, 2019 •
edited by lilin90
Loading

dcalvin
dcalvin reviewed May 20, 2019
View reviewed changes
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments and edits in line.

tools/lightning/monitor.md Outdated Show resolved Hide resolved
tools/lightning/monitor.md Outdated Show resolved Hide resolved
tools/lightning/monitor.md Outdated Show resolved Hide resolved
tools/lightning/monitor.md Outdated Show resolved Hide resolved
tools/lightning/monitor.md Outdated Show resolved Hide resolved
tools/lightning/monitor.md Outdated Show resolved Hide resolved
@dcalvin dcalvin requested a review from kennytm May 20, 2019 12:25
kennytm
kennytm reviewed May 20, 2019
View reviewed changes
tools/lightning/deployment.md Outdated Show resolved Hide resolved
tools/lightning/monitor.md Outdated Show resolved Hide resolved
@huangxiuyan
Copy link
Contributor Author

@dcalvin @kennytm PTAL，thanks!

dcalvin
dcalvin suggested changes May 22, 2019
View reviewed changes
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huangxiuyan Please update as Kenny suggested. Thanks.

tools/lightning/monitor.md Outdated Show resolved Hide resolved
tools/lightning/monitor.md Outdated Show resolved Hide resolved
tools/lightning/deployment.md Outdated Show resolved Hide resolved
dcalvin
dcalvin reviewed May 23, 2019
View reviewed changes
tools/lightning/monitor.md Outdated Show resolved Hide resolved
huangxiuyan and others added 2 commits May 23, 2019 11:36
@huangxiuyan @dcalvin
Update tools/lightning/monitor.md
65228d4 
Co-Authored-By: Calvin Weng <wenghao@pingcap.com>
@huangxiuyan @dcalvin
Update tools/lightning/monitor.md
f04c0c8 
Co-Authored-By: Calvin Weng <wenghao@pingcap.com>
dcalvin
dcalvin approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kennytm
kennytm approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcalvin dcalvin merged commit e2c908f into pingcap:master May 24, 2019
@dcalvin dcalvin mentioned this pull request May 24, 2019
Merged
@lilin90
Copy link
Member

lilin90 commented May 24, 2019

@huangxiuyan The link in line 51 is incorrect.

lilin90 added a commit to lilin90/docs that referenced this pull request May 25, 2019
@lilin90
dev/reference: fix a broken link
b45adaa 
Related PR: pingcap/docs-cn#1334
@lilin90 lilin90 mentioned this pull request May 25, 2019
Merged
lilin90 added a commit to pingcap/docs that referenced this pull request May 25, 2019
@lilin90
dev/reference: fix a broken link (#1171)
3aceebf 
Related PR: pingcap/docs-cn#1334
@huangxiuyan huangxiuyan deleted the update-Lightning-docs-for-v2.1.9 branch May 29, 2019 08:06
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalvin dcalvin dcalvin approved these changes

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@huangxiuyan @lilin90 @kennytm @dcalvin @sre-bot