Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: add runaway queries #14242

Merged
merged 51 commits into from
Jun 26, 2023
Merged

resource_control: add runaway queries #14242

merged 51 commits into from
Jun 26, 2023

Conversation

Connor1996
Copy link
Member

@Connor1996 Connor1996 commented Jun 15, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add doc about runaway control based on resource group

截屏2023-06-15 20 25 45

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Connor1996
add runaway doc
7acbe33 
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2023
@Connor1996 Connor1996 mentioned this pull request Jun 15, 2023
Closed
28 tasks
@qiancai qiancai added v7.2 This PR/issue applies to TiDB v7.2. translation/doing This PR’s assignee is translating this PR. labels Jun 15, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 15, 2023
@hfxsd hfxsd added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. for-release This PR relates to a TiDB release but does not have a tracked feature. and removed for-release This PR relates to a TiDB release but does not have a tracked feature. labels Jun 15, 2023
hfxsd
hfxsd reviewed Jun 15, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jun 15, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jun 15, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jun 15, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jun 15, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
@pingcap pingcap deleted a comment from CabinfeverB Jun 15, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-19 03:36:18.805001528 +0000 UTC m=+575175.219605607: ☑️ agreed by hfxsd.
  • 2023-06-19 09:32:55.358503568 +0000 UTC m=+8940.759754016: ☑️ agreed by ran-huang.

CabinfeverB
CabinfeverB reviewed Jun 20, 2023
View reviewed changes
mysql-schema.md Outdated Show resolved Hide resolved
@hfxsd @CabinfeverB
Update mysql-schema.md
c706dc3 
Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
CabinfeverB
CabinfeverB reviewed Jun 21, 2023
View reviewed changes
mysql-schema.md Outdated Show resolved Hide resolved
@hfxsd @CabinfeverB
Apply suggestions from code review
eb6ed9a 
Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
glorv
glorv reviewed Jun 21, 2023
View reviewed changes
sql-statements/sql-statement-alter-resource-group.md Outdated
1 rows in set (1.30 sec)
```

```sql
ALTER RESOURCE GROUP rg1
RU_PER_SEC = 200
PRIORITY = LOW;
PRIORITY = LOW
QUERY_LIMIT = (EXEC_ELAPSED='1s' ACTION=COOLDOWN WATCH=EXACT[30s]);
Copy link
Contributor

@glorv glorv Jun 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CabinfeverB WATCH=EXACT[30s] 没看到 parser 有支持这个语法

@hfxsd @CabinfeverB
Apply suggestions from code review
2ccfd51 
Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com>
nolouch
nolouch reviewed Jun 25, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
ran-huang
ran-huang reviewed Jun 25, 2023
View reviewed changes
tidb-resource-control.md Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2023
@hfxsd @ran-huang
Update tidb-resource-control.md
b10fee4 
Co-authored-by: Ran <huangran.alex@gmail.com>
songrijie
songrijie reviewed Jun 25, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jun 26, 2023
View reviewed changes
mysql-schema.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jun 26, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jun 26, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd
hfxsd reviewed Jun 26, 2023
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
hfxsd and others added 2 commits June 26, 2023 09:50
@hfxsd @songrijie
Apply suggestions from code review
88305a6 
Co-authored-by: Roger Song <roger.song@pingcap.com>
@hfxsd
Merge branch 'master' into runaway
3875d60
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2023
@hfxsd hfxsd removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2023
@hfxsd
Copy link
Collaborator

hfxsd commented Jun 26, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit 252be09 into pingcap:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@hfxsd hfxsd hfxsd approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@songrijie songrijie songrijie approved these changes

@nolouch nolouch nolouch left review comments

@glorv glorv glorv left review comments

@HuSharp HuSharp HuSharp approved these changes

Assignees

@hfxsd hfxsd

Labels
approved area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v7.2 This PR/issue applies to TiDB v7.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Connor1996 @HuSharp @hfxsd @glorv @nolouch @songrijie @CabinfeverB @ran-huang @qiancai