Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include description about extending timeout of TiUP when force-init-stats is ON #16761

Merged
merged 14 commits into from
Mar 11, 2024

Conversation

songrijie
Copy link
Contributor

@songrijie songrijie commented Mar 6, 2024

What is changed, added or deleted? (Required)

When force-init-stats is ON, it could reach the timeout of TiDB rolling update. We includes additional description, list the necessary steps to avoid such problem.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • [] v8.0 (TiDB 8.0 versions)
  • [] v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2024
@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Mar 7, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 7, 2024
@qiancai qiancai self-assigned this Mar 7, 2024
@qiancai qiancai requested a review from jebter March 7, 2024 01:42
Copy link

ti-chi-bot bot commented Mar 7, 2024

@jebter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Mar 7, 2024

@kaaaaaaang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -25,6 +25,24 @@ aliases: ['/docs-cn/dev/upgrade-tidb-using-tiup/','/docs-cn/dev/how-to/upgrade/u
> - 如果原集群是 3.0 或 3.1 或更早的版本,不支持直接升级到 v7.6.0 及后续修订版本。你需要先从早期版本升级到 4.0 后,再从 4.0 升级到 v7.6.0 及后续修订版本。
> - 如果原集群是 6.2 之前的版本,升级到 6.2 及以上版本时,部分场景会遇到升级卡住的情况,你可以参考[如何解决升级卡住的问题](#42-升级到-v620-及以上版本时如何解决升级卡住的问题)。
> - 配置参数 [`server-version`](/tidb-configuration-file.md#server-version) 的值会被 TiDB 节点用于验证当前 TiDB 的版本。因此在进行 TiDB 集群升级前,请将 `server-version` 的值设置为空或者当前 TiDB 真实的版本值,避免出现非预期行为。
> - 配置项 [`performance.force-init-stats`](/tidb-configuration-file.md#force-init-stats-从-v657-和-v710-版本开始引入) 设置为 `ON` 会延长 TiDB 的启动时间,这可能会造成启动超时,升级失败。建议为 TiUP 设置更长的等待时间。
> * 可能影响的场景
> * 原集群版本低于 v6.5.6, v7.1.0 ( 没有配置项 `performance.force-init-stats` ),目标版本为 v7.2.0 及更高。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> * 原集群版本低于 v6.5.6, v7.1.0 ( 没有配置项 `performance.force-init-stats` ),目标版本为 v7.2.0 及更高
> - 原集群版本低于 v6.5.6v7.1.0(尚未支持 `performance.force-init-stats`,目标版本为 v7.2.0 或更高

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

> - 配置项 [`performance.force-init-stats`](/tidb-configuration-file.md#force-init-stats-从-v657-和-v710-版本开始引入) 设置为 `ON` 会延长 TiDB 的启动时间,这可能会造成启动超时,升级失败。建议为 TiUP 设置更长的等待时间。
> * 可能影响的场景
> * 原集群版本低于 v6.5.6, v7.1.0 ( 没有配置项 `performance.force-init-stats` ),目标版本为 v7.2.0 及更高。
> * 原集群版本高于 v6.5.7, v7.1.0 ,且配置项 `performance.force-init-stats` 被设置为 `ON`。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> * 原集群版本高于 v6.5.7, v7.1.0 ,且配置项 `performance.force-init-stats` 被设置为 `ON`。
> - 原集群版本高于 v6.5.6 和 v7.1.0 ,且配置项 `performance.force-init-stats` 被设置为 `ON`。

upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Mar 8, 2024

@hawkingrei: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 8, 2024
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 8, 2024
upgrade-tidb-using-tiup.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 8, 2024
Copy link

ti-chi-bot bot commented Mar 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-08 06:06:43.932381016 +0000 UTC m=+406430.954627426: ☑️ agreed by qiancai.
  • 2024-03-08 07:21:16.714602582 +0000 UTC m=+410903.736848955: ☑️ agreed by hfxsd.

Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qiancai
Copy link
Collaborator

qiancai commented Mar 11, 2024

/approve

Copy link

ti-chi-bot bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6051757 into master Mar 11, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the tiup-timeout-force-init-stats branch March 11, 2024 03:08
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16778.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants