-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include description about extending timeout of TiUP when force-init-stats is ON #16761
Conversation
@jebter: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kaaaaaaang: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
upgrade-tidb-using-tiup.md
Outdated
@@ -25,6 +25,24 @@ aliases: ['/docs-cn/dev/upgrade-tidb-using-tiup/','/docs-cn/dev/how-to/upgrade/u | |||
> - 如果原集群是 3.0 或 3.1 或更早的版本,不支持直接升级到 v7.6.0 及后续修订版本。你需要先从早期版本升级到 4.0 后,再从 4.0 升级到 v7.6.0 及后续修订版本。 | |||
> - 如果原集群是 6.2 之前的版本,升级到 6.2 及以上版本时,部分场景会遇到升级卡住的情况,你可以参考[如何解决升级卡住的问题](#42-升级到-v620-及以上版本时如何解决升级卡住的问题)。 | |||
> - 配置参数 [`server-version`](/tidb-configuration-file.md#server-version) 的值会被 TiDB 节点用于验证当前 TiDB 的版本。因此在进行 TiDB 集群升级前,请将 `server-version` 的值设置为空或者当前 TiDB 真实的版本值,避免出现非预期行为。 | |||
> - 配置项 [`performance.force-init-stats`](/tidb-configuration-file.md#force-init-stats-从-v657-和-v710-版本开始引入) 设置为 `ON` 会延长 TiDB 的启动时间,这可能会造成启动超时,升级失败。建议为 TiUP 设置更长的等待时间。 | |||
> * 可能影响的场景 | |||
> * 原集群版本低于 v6.5.6, v7.1.0 ( 没有配置项 `performance.force-init-stats` ),目标版本为 v7.2.0 及更高。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> * 原集群版本低于 v6.5.6, v7.1.0 ( 没有配置项 `performance.force-init-stats` ),目标版本为 v7.2.0 及更高。 | |
> - 原集群版本低于 v6.5.6 和 v7.1.0(尚未支持 `performance.force-init-stats`),目标版本为 v7.2.0 或更高。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
upgrade-tidb-using-tiup.md
Outdated
> - 配置项 [`performance.force-init-stats`](/tidb-configuration-file.md#force-init-stats-从-v657-和-v710-版本开始引入) 设置为 `ON` 会延长 TiDB 的启动时间,这可能会造成启动超时,升级失败。建议为 TiUP 设置更长的等待时间。 | ||
> * 可能影响的场景 | ||
> * 原集群版本低于 v6.5.6, v7.1.0 ( 没有配置项 `performance.force-init-stats` ),目标版本为 v7.2.0 及更高。 | ||
> * 原集群版本高于 v6.5.7, v7.1.0 ,且配置项 `performance.force-init-stats` 被设置为 `ON`。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> * 原集群版本高于 v6.5.7, v7.1.0 ,且配置项 `performance.force-init-stats` 被设置为 `ON`。 | |
> - 原集群版本高于 v6.5.6 和 v7.1.0 ,且配置项 `performance.force-init-stats` 被设置为 `ON`。 |
@hawkingrei: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Roger Song <roger.song@pingcap.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
What is changed, added or deleted? (Required)
When
force-init-stats
isON
, it could reach the timeout of TiDB rolling update. We includes additional description, list the necessary steps to avoid such problem.Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?