Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update lightning conflict detection recording view #17648

Merged
merged 15 commits into from
Jul 2, 2024
Merged

update lightning conflict detection recording view #17648

merged 15 commits into from
Jul 2, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jun 11, 2024

What is changed, added or deleted? (Required)

Update lightning conflict detection recording view.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. translation/from-docs This PR is translated from a PR in pingcap/docs. v8.2 labels Jun 11, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2024
@qiancai qiancai self-assigned this Jun 11, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2024
@qiancai qiancai requested a review from lyzx2001 June 11, 2024 09:41
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 11, 2024

@lyzx2001: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt self-requested a review June 12, 2024 02:54
@qiancai @lyzx2001
Update tidb-lightning/tidb-lightning-physical-import-mode-usage.md
e57cfeb 
Co-authored-by: Luo Yangzhixin <rep_laureline@hotmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 17, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-17 08:02:57.246849135 +0000 UTC m=+15503.732337967: ☑️ agreed by Oreoxmt.

@qiancai qiancai added the for-release This PR relates to a TiDB release but does not have a tracked feature. label Jun 20, 2024
@qiancai
Copy link
Collaborator Author

qiancai commented Jun 27, 2024

/approve

@qiancai qiancai added the lgtm label Jun 27, 2024
@ti-chi-bot ti-chi-bot bot added the approved label Jun 27, 2024
@qiancai qiancai added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 1, 2024
@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2024
@qiancai
Copy link
Collaborator Author

qiancai commented Jul 2, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 42c6d25 into pingcap:master Jul 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyzx2001 lyzx2001 lyzx2001 approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@qiancai qiancai

Labels
approved area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. v8.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiancai @Oreoxmt @lyzx2001