dev: remove transaction kv count limit #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
|
@tennix PTAL |
|
@tennix PTAL |
|
@DanielZhangQD PTAL |
| @@ -110,9 +110,6 @@ TiDB Operator 使用 Helm 部署和管理 TiDB 集群。通过 Helm 获取的配 | |||
| | `tidb.txnLocalLatchesCapacity` | 事务内存锁的容量，Hash 对应的 slot 数，会自动向上调整为 2 的指数倍。每个 slot 占 32 Bytes 内存。当写入数据的范围比较广时（如导数据），设置过小会导致变慢，性能下降。<br>如果 TiDB Operator 版本 > v1.0.0-beta.3，请通过 `tidb.config` 配置：<br>`[txn-local-latches]`<br>`capacity = 10240000` | `10240000` | | |||
| | `tidb.tokenLimit` | TiDB 并发执行会话的限制<br>如果 TiDB Operator 版本 > v1.0.0-beta.3，请通过 `tidb.config` 配置：<br>`token-limit = 1000` | `1000` | | |||
| | `tidb.memQuotaQuery` | TiDB 查询的内存限额，默认 32GB<br>如果 TiDB Operator 版本 > v1.0.0-beta.3，请通过 `tidb.config` 配置：<br>`mem-quota-query = 34359738368` | `34359738368` | | |||
| | `tidb.txnEntryCountLimit` | 一个事务中条目的数目限制。如果使用 TiKV 作为存储，则条目表示键/值对。**警告**：不要将该值设置得太大，否则会对 TiKV 集群造成很大影响。请仔细调整此配置<br>如果 TiDB Operator 版本 > v1.0.0-beta.3，请通过 `tidb.config` 配置：<br>`[performance]`<br>`txn-entry-count-limit = 300000` | `300000` | | |||
There was a problem hiding this comment.
TiDB Operator supports different versions of TiKV, we cannot just remove the config, suggest to make it clear in which TiKV version that this parameter does not need to set.
There was a problem hiding this comment.
I just change the docs for dev version, it means it will not work in the master branch. I think the Operator should follow the same rule.
DanielZhangQD
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Confirmed with @jackysp , the removed parameters in tidb-cluster.md should not be exposed to users to configure, so it's OK to remove them from the doc.
LGTM
TomShawn
added
translation/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shuaipeng Yu jackysp@gmail.com
What is changed, added or deleted?
What is the related PR or file link(s)?
pingcap/tidb#11141
Which version does your change affect?
dev