Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiDB vector search doc #18502

Merged
merged 121 commits into from
Oct 22, 2024
Merged

TiDB vector search doc #18502

merged 121 commits into from
Oct 22, 2024

Conversation

EricZequan
Copy link
Contributor

@EricZequan EricZequan commented Sep 2, 2024 •
edited by JaySon-Huang
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions))

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@EricZequan
TiDB vector data type and vector index Doc
48f906c 
Signed-off-by: “EricZequan” <zequany33@gmail.com>
@ti-chi-bot ti-chi-bot bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Sep 2, 2024
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 2, 2024
@EricZequan
remove vector index part
0b31525 
Signed-off-by: “EricZequan” <zequany33@gmail.com>
@qiancai qiancai self-requested a review September 2, 2024 06:48
@qiancai qiancai added v8.4 This PR/issue applies to TiDB v8.4. translation/doing This PR’s assignee is translating this PR. labels Sep 2, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 2, 2024
@EricZequan
Copy link
Contributor Author

/cc @breezewish

@ti-chi-bot ti-chi-bot bot requested a review from breezewish September 2, 2024 07:50
@qiancai qiancai self-assigned this Sep 2, 2024
@EricZequan
modify cluster type
96f2701 
Signed-off-by: “EricZequan” <zequany33@gmail.com>
@EricZequan
fix
3fdab1b 
Signed-off-by: “EricZequan” <zequany33@gmail.com>
breezewish
breezewish reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有些累，基本每一行我都提了一个 comment 以便让这个文本读起来更正常，请自行对其他文档进行这样的改动，让它变得可读，尤其需要注意语序上中文和英文语序是不一样的，你需要调整各行的语序、必要的时候补充一些细节，使得内容是读起来是顺畅的、符合中文语法的、易于理解的。英文文档由于大家水平问题并不一定每句话都能表达清楚，也不强求，意思到了就可以，但作为母语的中文文档，应当具备最完备、最易于理解、最没有歧义的内容，因此必要的时候需要扩写、澄清一些细节。

vector-search-data-types.md Outdated Show resolved Hide resolved
vector-search-data-types.md Outdated Show resolved Hide resolved
vector-search-data-types.md Outdated Show resolved Hide resolved
vector-search-data-types.md Outdated Show resolved Hide resolved
vector-search-data-types.md Outdated Show resolved Hide resolved
vector-search-data-types.md Outdated Show resolved Hide resolved
vector-search-data-types.md Outdated Show resolved Hide resolved
vector-search-data-types.md Outdated Show resolved Hide resolved
vector-search-data-types.md Outdated Show resolved Hide resolved
vector-search-data-types.md Outdated Show resolved Hide resolved
@EricZequan
modify expression
98e417b 
Signed-off-by: “EricZequan” <zequany33@gmail.com>
@EricZequan
fix ci
9bd83d6 
Signed-off-by: “EricZequan” <zequany33@gmail.com>
qiancai
qiancai reviewed Oct 21, 2024
View reviewed changes
vector-search-overview.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Oct 21, 2024
Preview PR pingcap/docs-cn#18502 and this preview is triggered from c…
e4043d7 
…ommit pingcap/docs-cn@d82bb79
@EricZequan
add ORM-non-index doc
c4d049e 
Signed-off-by: “EricZequan” <zequany33@gmail.com>
@EricZequan
Revert "remove part of ORM intro"
cc21bc8 
This reverts commit b8a100a.
github-actions bot pushed a commit to qiancai/pingcap-docsite-preview that referenced this pull request Oct 21, 2024
Preview PR pingcap/docs-cn#18502 and this preview is triggered from c…
c275977 
…ommit pingcap/docs-cn@cc21bc8
zimulala
zimulala reviewed Oct 21, 2024
View reviewed changes
vector-search-index.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 21, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-11 03:41:29.537617583 +0000 UTC m=+414159.278041518: ☑️ agreed by Icemap.
  • 2024-10-21 08:29:51.166475032 +0000 UTC m=+253391.863265640: ☑️ agreed by hfxsd.

JaySon-Huang
JaySon-Huang reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricZequan
fix comment
b50a16e 
Signed-off-by: “EricZequan” <zequany33@gmail.com>
@EricZequan
Copy link
Contributor Author

LGTM

lilin90
lilin90 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. translation/doing This PR’s assignee is translating this PR. labels Oct 22, 2024
@qiancai
Copy link
Collaborator

qiancai commented Oct 22, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 65ad55d into pingcap:master Oct 22, 2024
6 of 7 checks passed
@JaySon-Huang JaySon-Huang mentioned this pull request Oct 23, 2024
Merged
16 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 28, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@wk989898 wk989898 wk989898 left review comments

@Icemap Icemap Icemap approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@zimulala zimulala zimulala left review comments

@breezewish breezewish breezewish left review comments

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@hfxsd hfxsd hfxsd approved these changes

@lilin90 lilin90 lilin90 approved these changes

Assignees

@qiancai qiancai

Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.