Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add quick started for lightning #1948

Merged
merged 14 commits into from
Nov 4, 2019
Merged

tools: add quick started for lightning #1948

merged 14 commits into from
Nov 4, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

What is changed, added or deleted?

add quick started for lightning

Which version does your change affect?

only update dev now, will update v2.1 and v3.0 after get two LGTM

@WangXiangUSTC
Copy link
Contributor Author

@kennytm PTAL

@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Oct 15, 2019
@kennytm
Copy link
Contributor

kennytm commented Oct 28, 2019

LGTM

PTAL @lilin90

@WangXiangUSTC WangXiangUSTC requested a review from yikeke October 28, 2019 08:41
@WangXiangUSTC
Copy link
Contributor Author

@yikeke PTAL

yikeke
yikeke reviewed Oct 29, 2019
View reviewed changes
dev/how-to/get-started/tidb-lightning.md Outdated Show resolved Hide resolved
dev/how-to/get-started/tidb-lightning.md Outdated Show resolved Hide resolved
dev/how-to/get-started/tidb-lightning.md Outdated Show resolved Hide resolved
dev/how-to/get-started/tidb-lightning.md Outdated Show resolved Hide resolved
dev/how-to/get-started/tidb-lightning.md Outdated Show resolved Hide resolved
dev/how-to/get-started/tidb-lightning.md Outdated Show resolved Hide resolved
dev/how-to/get-started/tidb-lightning.md Outdated

1. 从安装包上传 `bin/tidb-lightning` 及 `bin/tidb-lightning-ctl`。

2. 将数据源写入到同样的机器。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

”同样的机器“是指前一步中上传的服务器吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的，就是把 mydumper 导出的全量数据也上传到这台服务器

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在 33da344 里更新了描述

dev/how-to/get-started/tidb-lightning.md Outdated Show resolved Hide resolved
dev/how-to/get-started/tidb-lightning.md Outdated Show resolved Hide resolved
dev/how-to/get-started/tidb-lightning.md Outdated Show resolved Hide resolved
@yikeke yikeke added the suggestion/queeny-test Suggest doing user acceptance testing for documentation. label Oct 29, 2019
@WangXiangUSTC
Copy link
Contributor Author

@yikeke thanks，PTAL again

yikeke
yikeke reviewed Nov 1, 2019
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

yikeke
yikeke reviewed Nov 1, 2019
View reviewed changes
dev/how-to/get-started/tidb-lightning.md Outdated

### 第 3 步：启动 `tikv-importer`

1. 将安装包里的 `bin/tikv-importer` 上传服务器。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. 将安装包里的 `bin/tikv-importer` 上传服务器。
1. 将安装包里的 `bin/tikv-importer` 上传至部署 TiDB Lightning 的服务器。

dev/how-to/get-started/tidb-lightning.md Outdated Show resolved Hide resolved
dev/how-to/get-started/tidb-lightning.md Outdated Show resolved Hide resolved
yikeke
yikeke approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC merged commit e099b79 into pingcap:master Nov 4, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/lightning_quick_start branch November 4, 2019 02:53
@TomShawn TomShawn mentioned this pull request Nov 8, 2019
Merged
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@yikeke yikeke yikeke approved these changes

Assignees

@TomShawn TomShawn

Labels
suggestion/queeny-test Suggest doing user acceptance testing for documentation. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WangXiangUSTC @kennytm @yikeke @lilin90 @TomShawn