Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-lightning: add glossary #2214

Merged
merged 4 commits into from
Feb 17, 2020

Conversation

anotherrachel
Copy link
Contributor

@anotherrachel anotherrachel commented Feb 6, 2020

What is changed, added or deleted?

This PR adds a glossary for TiDB-lightning.

What is the related PR or file link(s)?

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

@anotherrachel anotherrachel added translation/from-docs This PR is translated from a PR in pingcap/docs. dev size/medium Changes of a medium size. labels Feb 6, 2020
@anotherrachel anotherrachel marked this pull request as ready for review February 10, 2020 11:33
dev/TOC.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some links need to be modified. Mostly LGTM. Great job!

dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/glossary.md Outdated Show resolved Hide resolved
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PTAL again. @kennytm

@kennytm
Copy link
Contributor

kennytm commented Feb 17, 2020

But is it still [DNM]?

@anotherrachel anotherrachel added v2.1 and removed DNM labels Feb 17, 2020
@anotherrachel
Copy link
Contributor Author

But is it still [DNM]?

Updated the labels. PTAL, thanks! @kennytm

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

anotherrachel and others added 4 commits February 17, 2020 21:39
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
@anotherrachel anotherrachel merged commit 7131436 into pingcap:master Feb 17, 2020
@anotherrachel anotherrachel deleted the lightning-glossary branch February 18, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium Changes of a medium size. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants