-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidb-lightning: add glossary #2214
tidb-lightning: add glossary #2214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some links need to be modified. Mostly LGTM. Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. PTAL again. @kennytm
But is it still [DNM]? |
Updated the labels. PTAL, thanks! @kennytm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: Keke Yi <40977455+yikeke@users.noreply.github.com>
f5560b8
to
f1db475
Compare
What is changed, added or deleted?
This PR adds a glossary for TiDB-lightning.
What is the related PR or file link(s)?
Which TiDB version(s) does your changes apply to?
Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.