Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: clarify unsupported behavior in generated column #2262

Merged
merged 7 commits into from
Feb 21, 2020

Conversation

Deardrops
Copy link
Contributor

What is changed, added or deleted?

We fix logs of bugs related to generated column in TiDB v4.0, for the known unsupported behavior in v4.0 and previous versions, we should update the docs.

What is the related PR or file link(s)?

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

@Deardrops Deardrops self-assigned this Feb 20, 2020
@Deardrops Deardrops added dev v4.0 This PR/issue applies to TiDB v4.0. labels Feb 20, 2020
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Feb 20, 2020
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dev/reference/sql/generated-columns.md Outdated Show resolved Hide resolved
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

v2.1/reference/sql/generated-columns.md Outdated Show resolved Hide resolved
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 21, 2020

/run-all-tests

@sre-bot sre-bot merged commit e8a82d9 into pingcap:master Feb 21, 2020
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v4.0 This PR/issue applies to TiDB v4.0.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants