Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-statement-explain-analyze: add note for explain analyze with DML #4059

Merged
merged 3 commits into from
Jul 28, 2020
Merged

sql-statement-explain-analyze: add note for explain analyze with DML #4059

merged 3 commits into from
Jul 28, 2020

Conversation

SunRunAway
Copy link
Contributor

@SunRunAway SunRunAway commented Jul 27, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Jul 27, 2020
@TomShawn TomShawn self-assigned this Jul 27, 2020
@TomShawn
Copy link
Contributor

@SunRunAway Please also involve a technical review.

@SunRunAway @TomShawn
Update sql-statements/sql-statement-explain-analyze.md
d3078ae 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@SunRunAway SunRunAway mentioned this pull request Jul 27, 2020
Closed
7 tasks
@SunRunAway
Copy link
Contributor Author

@crazycs520 PTAL

crazycs520
crazycs520 reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2020
TomShawn
TomShawn approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 28, 2020
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 4057

@ti-srebot
Copy link
Contributor

/run-all-tests

@TomShawn TomShawn merged commit 60ddb9e into pingcap:master Jul 28, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 28, 2020
@SunRunAway @ti-srebot
cherry pick pingcap#4059 to release-4.0
c3ce81f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 28, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4063

ti-srebot added a commit that referenced this pull request Jul 28, 2020
@ti-srebot @SunRunAway
sql-statement-explain-analyze: add note for explain analyze with DML (#…
e91c2bf 
…4059) (#4063)

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 10, 2020
@TomShawn TomShawn mentioned this pull request Aug 10, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Aug 11, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@TomShawn TomShawn TomShawn approved these changes

Assignees

@TomShawn TomShawn

Labels
size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SunRunAway @TomShawn @ti-srebot @crazycs520