Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releases: add tidb 5.0-rc release notes #5295

Merged
merged 12 commits into from
Jan 12, 2021
Merged

releases: add tidb 5.0-rc release notes #5295

merged 12 commits into from
Jan 12, 2021

Conversation

CharLotteiu
Copy link
Contributor

@CharLotteiu CharLotteiu commented Jan 12, 2021 •
edited by TomShawn
Loading

What is changed, added or deleted? (Required)

  • Add TiDB 5.0-rc release notes
  • Uncomment v5.0 version marks
  • Update anchors
  • Minor wording changes
  • Add What's New in TiDB 5.0 to TOC and _index.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@CharLotteiu CharLotteiu added needs-cherry-pick-5.0 status/PTAL This PR is ready for reviewing. translation/doing This PR’s assignee is translating this PR. labels Jan 12, 2021
@CharLotteiu CharLotteiu requested a review from TomShawn January 12, 2021 06:32
@CharLotteiu CharLotteiu changed the title Add 5.0-rc release notes releases: add tidb 5.0-rc release notes Jan 12, 2021
@CharLotteiu CharLotteiu mentioned this pull request Jan 12, 2021
Merged
10 tasks
@CharLotteiu CharLotteiu added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jan 12, 2021
@TomShawn TomShawn self-assigned this Jan 12, 2021
@TomShawn TomShawn mentioned this pull request Jan 12, 2021
Closed
9 tasks
@TomShawn TomShawn requested a review from scsldb January 12, 2021 07:59
@TomShawn TomShawn added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jan 12, 2021
@scsldb
Copy link
Contributor

scsldb commented Jan 12, 2021

LGTM

@ti-srebot
Copy link
Contributor

@scsldb, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn
TomShawn approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 12, 2021
@TomShawn TomShawn merged commit 60ce14a into pingcap:master Jan 12, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jan 12, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5295 to release-5.0
46dc239 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
This was referenced Jan 12, 2021
Merged
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5301

TomShawn added a commit that referenced this pull request Jan 12, 2021
@ti-srebot @CharLotteiu @TomShawn
releases: add tidb 5.0-rc release notes (#5295) (#5301)
02ae7dd 
* cherry pick #5295 to release-5.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflicts

Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@CharLotteiu CharLotteiu deleted the add-5.0-rc-release-notes branch January 18, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@scsldb scsldb Awaiting requested review from scsldb

Assignees

@TomShawn TomShawn

Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharLotteiu @scsldb @ti-srebot @TomShawn