Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update the usage of region startkey to region keys #7637

Merged
merged 4 commits into from
Feb 9, 2022
Merged

tools: update the usage of region startkey to region keys #7637

merged 4 commits into from
Feb 9, 2022

Conversation

IcePigZDB
Copy link
Contributor

@IcePigZDB IcePigZDB commented Nov 23, 2021 •
edited
Loading

Signed-off-by: IcePigZDB icepigzdb@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Support endKey in http interface regions/key and adjust the pdctl region command region startKey to region keysaccordingly. This is originally proposed as a precondition of the push down optimisation of infomation_schema.tikv_region_status.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@IcePigZDB
tools: update the usage of region startkey to region keys
bc5be36 
Signed-off-by: IcePigZDB <icepigzdb@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Nov 23, 2021
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2021
This was referenced Nov 23, 2021
Open
Open
@IcePigZDB
tools: update region keys
00cc175 
Signed-off-by: IcePigZDB <icepigzdb@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2021
@IcePigZDB IcePigZDB marked this pull request as ready for review November 29, 2021 13:24
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2021
@IcePigZDB IcePigZDB mentioned this pull request Nov 29, 2021
Merged
15 tasks
@IcePigZDB
tools: update
8ba0040 
Signed-off-by: IcePigZDB <icepigzdb@gmail.com>
@IcePigZDB
Copy link
Contributor Author

/cc @TomShawn

@TomShawn
Copy link
Contributor

TomShawn commented Dec 2, 2021

@IcePigZDB Since you have added a tickbox v5.4, is this a v5.4 feature?

@TomShawn TomShawn added the for-future-release This PR only applies to master for now and might cherry-pick to a future release. label Dec 6, 2021
@IcePigZDB
Copy link
Contributor Author

@IcePigZDB Since you have added a tickbox v5.4, is this a v5.4 feature?

yes, if anything change, I will keep you informed.

@TomShawn TomShawn requested a review from nolouch January 12, 2022 14:46
@nolouch
Copy link
Member

nolouch commented Jan 18, 2022

PTAL @TomShawn

@TomShawn TomShawn added v5.4 This PR/issue applies to TiDB v5.4. and removed for-future-release This PR only applies to master for now and might cherry-pick to a future release. v5.4 This PR/issue applies to TiDB v5.4. labels Jan 28, 2022
TomShawn
TomShawn reviewed Feb 9, 2022
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Feb 9, 2022
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Feb 9, 2022
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Feb 9, 2022
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Feb 9, 2022
View reviewed changes
pd-control.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 9, 2022
@TomShawn TomShawn added area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. v5.4 This PR/issue applies to TiDB v5.4. and removed missing-translation-status This PR does not have translation status info. labels Feb 9, 2022
@TomShawn TomShawn added the translation/doing This PR’s assignee is translating this PR. label Feb 9, 2022
@TomShawn TomShawn self-assigned this Feb 9, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Feb 9, 2022

/merge

@ti-chi-bot
Copy link
Member

@TomShawn: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 9, 2022
@TomShawn TomShawn assigned IcePigZDB and unassigned TomShawn Feb 9, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Feb 9, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 9, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Feb 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2476382

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 9, 2022
@ti-chi-bot ti-chi-bot merged commit 343a916 into pingcap:master Feb 9, 2022
@IcePigZDB IcePigZDB mentioned this pull request Feb 24, 2022
Merged
16 tasks
This was referenced May 13, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@TomShawn TomShawn Awaiting requested review from TomShawn

Assignees

@IcePigZDB IcePigZDB

Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v5.4 This PR/issue applies to TiDB v5.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IcePigZDB @ti-chi-bot @TomShawn @nolouch