zh,en: update dmctl commands #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMHDBJD
commented
Dec 18, 2020
Comment on lines
+29
to
+33
| Release Version: v2.0.0 | ||
| Git Commit Hash: e6ca256257fbe6e744892841537a16eb84469116 | ||
| Git Branch: release-2.0 | ||
| UTC Build Time: 2020-10-30 07:43:00 | ||
| Go Version: go version go1.13 linux/amd64 |
There was a problem hiding this comment.
use v2.0.0 since we now have no hash and build time for v2.0.1
CharLotteiu
added
needs-cherry-pick-release-2.0
csuzhangxc
reviewed
Dec 18, 2020
en/dmctl-introduction.md
Outdated
| @@ -21,16 +21,16 @@ Enter the interactive mode to interact with DM-master: | |||
| {{< copyable "shell-regular" >}} | |||
|
|
|||
| ```bash | |||
| ./dmctl -master-addr 172.16.30.14:8261 | |||
| ./dmctl -master-addr 172.16.30.14:8261,172.16.30.15:8261 | |||
There was a problem hiding this comment.
How about addressing this behavior was introduced in v2.0.1? (if so, do not forget to update other places in this PR) and in most cases, only one endpoint is enough.
There was a problem hiding this comment.
You are right. I remove all of them. 😂
CharLotteiu
reviewed
Dec 18, 2020
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
ti-srebot
approved these changes
Dec 18, 2020
|
Should we merge this PR after v2.0.1 is released? @csuzhangxc @GMHDBJD |
YES, and #516, #517, #518 should be merged after v2.0.1 released. |
|
@csuzhangxc, @CharLotteiu, @yikeke, @ti-srebot, PTAL. |
|
@csuzhangxc, @CharLotteiu, @yikeke, PTAL. |
ti-srebot
pushed a commit
to ti-srebot/docs-dm
that referenced
this pull request
Dec 25, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
7 tasks
|
cherry pick to release-2.0 in PR #531 |
CharLotteiu
pushed a commit
that referenced
this pull request
Dec 25, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: GMHDBJD <35025882+GMHDBJD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added, or deleted? (Required)
update dmctl command for v2.0.1
Which DM version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
pingcap/dm#1333
pingcap/dm#1316
pingcap/dm#1323
Do your changes match any of the following descriptions?