Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh: update get-started and related tutorials #526

Merged
merged 11 commits into from
Jul 7, 2020

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Jul 2, 2020

What is changed, added or deleted? (Required)

fixes #433

gke cloud shell: https://console.cloud.google.com/cloudshell/open?cloudshell_git_repo=https://github.com/cofyc/docs-tidb-operator&cloudshell_tutorial=zh/deploy-tidb-from-kubernetes-gke.md&cloudshell_git_branch=fix433

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.1 (TiDB Operator 1.1 versions)
  • v1.0 (TiDB Operator 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@cofyc cofyc force-pushed the fix433 branch 2 times, most recently from 71946c7 to c0ecac3 Compare July 2, 2020 12:14
@cofyc cofyc changed the title [WIP] zh: align get-started docs [WIP] zh: update get-started and related tutorials Jul 2, 2020
@cofyc cofyc changed the title [WIP] zh: update get-started and related tutorials zh: update get-started and related tutorials Jul 2, 2020
kubectl create namespace tidb-admin
helm install --namespace tidb-admin tidb-operator pingcap/tidb-operator --version v1.1.2
kubectl get po -n tidb-admin -l app.kubernetes.io/name=tidb-operator
```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to install pd-ssd storage class anymore
https://github.com/pingcap/docs-tidb-operator/pull/527/files#r448768118

在 Cloud Shell 中,点击 Web Preview 按钮并输入端口 3000,将打开一个新的浏览器标签页访问 Grafana 面板。或者也可以在新浏览器标签或者窗口中直接访问 URL:<https://ssh.cloud.google.com/devshell/proxy?port=3000>。
在 Cloud Shell 中,点击右上方的 Web Preview 按钮并修改端口为 8080 后点击预览,将打开一个新的浏览器标签页访问 Grafana 面板。或者也可以在新浏览器标签或者窗口中直接访问 URL:<https://ssh.cloud.google.com/devshell/proxy?port=8080>。

如果没有使用 Cloud Shell,可以在浏览器中访问 `localhost:8080`。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cofyc cofyc force-pushed the fix433 branch 3 times, most recently from ebcc197 to a19abdf Compare July 2, 2020 12:28
@cofyc cofyc added the needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. label Jul 2, 2020
@ran-huang ran-huang added the translation/from-en This PR is translated from a PR in docs-tidb-operator/en. label Jul 3, 2020
@cofyc cofyc mentioned this pull request Jul 6, 2020
3 tasks
zh/_index.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
zh/tidb-operator-overview.md Outdated Show resolved Hide resolved
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

zh/deploy-tidb-operator.md Outdated Show resolved Hide resolved
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2020
@ti-srebot
Copy link
Contributor

@DanielZhangQD,Thanks for your review.

@DanielZhangQD
Copy link
Contributor

@cofyc Please fix the CI.

@ran-huang
Copy link
Contributor

@cofyc Please also delete the files of kind and minikube, since they are now integrated into get-started.

cofyc and others added 8 commits July 7, 2020 15:00
Thanks for the review!

Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
@cofyc
Copy link
Contributor Author

cofyc commented Jul 7, 2020

@ran-huang @DanielZhangQD PTAL

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang ran-huang self-requested a review July 7, 2020 08:27
@cofyc
Copy link
Contributor Author

cofyc commented Jul 7, 2020

pushed a new commit (2840470) to sync the change from #542

zh/get-started.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
zh/get-started.md Outdated Show resolved Hide resolved
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 7, 2020
@ti-srebot
Copy link
Contributor

@ran-huang,Thanks for your review.

@DanielZhangQD DanielZhangQD merged commit 925201c into pingcap:master Jul 7, 2020
ti-srebot pushed a commit to ti-srebot/docs-tidb-operator that referenced this pull request Jul 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #545

DanielZhangQD pushed a commit that referenced this pull request Jul 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Yecheng Fu <fuyecheng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-1.1 Should cherry pick this PR to release-1.1 branch. status/LGT2 Indicates that a PR has LGTM 2. translation/from-en This PR is translated from a PR in docs-tidb-operator/en.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zh: align get started tutorial
4 participants