-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zh: update get-started and related tutorials #526
Conversation
71946c7
to
c0ecac3
Compare
kubectl create namespace tidb-admin | ||
helm install --namespace tidb-admin tidb-operator pingcap/tidb-operator --version v1.1.2 | ||
kubectl get po -n tidb-admin -l app.kubernetes.io/name=tidb-operator | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to install pd-ssd storage class anymore
https://github.com/pingcap/docs-tidb-operator/pull/527/files#r448768118
在 Cloud Shell 中,点击 Web Preview 按钮并输入端口 3000,将打开一个新的浏览器标签页访问 Grafana 面板。或者也可以在新浏览器标签或者窗口中直接访问 URL:<https://ssh.cloud.google.com/devshell/proxy?port=3000>。 | ||
在 Cloud Shell 中,点击右上方的 Web Preview 按钮并修改端口为 8080 后点击预览,将打开一个新的浏览器标签页访问 Grafana 面板。或者也可以在新浏览器标签或者窗口中直接访问 URL:<https://ssh.cloud.google.com/devshell/proxy?port=8080>。 | ||
|
||
如果没有使用 Cloud Shell,可以在浏览器中访问 `localhost:8080`。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ebcc197
to
a19abdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
@DanielZhangQD,Thanks for your review. |
@cofyc Please fix the CI. |
@cofyc Please also delete the files of kind and minikube, since they are now integrated into get-started. |
Thanks for the review! Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
@ran-huang @DanielZhangQD PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ran-huang,Thanks for your review. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-1.1 in PR #545 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Yecheng Fu <fuyecheng@pingcap.com>
What is changed, added or deleted? (Required)
fixes #433
gke cloud shell: https://console.cloud.google.com/cloudshell/open?cloudshell_git_repo=https://github.com/cofyc/docs-tidb-operator&cloudshell_tutorial=zh/deploy-tidb-from-kubernetes-gke.md&cloudshell_git_branch=fix433
Which TiDB Operator version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?